Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-31 Thread Rob Herring 
On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property. Fix example.
> 
> Signed-off-by: Johan Jonker 
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml 
> b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>- const: default
>- const: unwedge
> 
> +  power-domains:
> +maxItems: 1
> +
>ports:
>  $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  hdmi: hdmi@ff98 {
>  compatible = "rockchip,rk3288-dw-hdmi";
>  reg = <0xff98 0x2>;
> -reg-io-width = <4>;

It makes more sense to keep reg-io-width together with reg.

> -ddc-i2c-bus = <>;
> -rockchip,grf = <>;
>  interrupts = ;
>  clocks = <  PCLK_HDMI_CTRL>, < SCLK_HDMI_HDCP>;
>  clock-names = "iahb", "isfr";
> +ddc-i2c-bus = <>;
> +power-domains = < RK3288_PD_VIO>;
> +reg-io-width = <4>;
> +rockchip,grf = <>;
> 
>  ports {
>  #address-cells = <1>;
> --
> 2.39.2
>

Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-30 Thread Conor Dooley 
On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote:
> Most Rockchip hdmi nodes are part of a power domain.
> Add a power-domains property.

Acked-by: Conor Dooley 

> Fix example.

Just a note, in the future please explain why simply reordering the
properties constitutes "fixing" the example. I figure your intention is
to align with the (new) documentation about property ordering.

Thanks,
Conor.

> 
> Signed-off-by: Johan Jonker 
> ---
>  .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml 
> b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index cd0a42f35f24..6f421740b613 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -94,6 +94,9 @@ properties:
>- const: default
>- const: unwedge
> 
> +  power-domains:
> +maxItems: 1
> +
>ports:
>  $ref: /schemas/graph.yaml#/properties/ports
> 
> @@ -141,16 +144,18 @@ examples:
>  #include 
>  #include 
>  #include 
> +#include 
> 
>  hdmi: hdmi@ff98 {
>  compatible = "rockchip,rk3288-dw-hdmi";
>  reg = <0xff98 0x2>;
> -reg-io-width = <4>;
> -ddc-i2c-bus = <>;
> -rockchip,grf = <>;
>  interrupts = ;
>  clocks = <  PCLK_HDMI_CTRL>, < SCLK_HDMI_HDCP>;
>  clock-names = "iahb", "isfr";
> +ddc-i2c-bus = <>;
> +power-domains = < RK3288_PD_VIO>;
> +reg-io-width = <4>;
> +rockchip,grf = <>;
> 
>  ports {
>  #address-cells = <1>;
> --
> 2.39.2
> 
> 


signature.asc
Description: PGP signature

[PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-30 Thread Johan Jonker 
Most Rockchip hdmi nodes are part of a power domain.
Add a power-domains property. Fix example.

Signed-off-by: Johan Jonker 
---
 .../bindings/display/rockchip/rockchip,dw-hdmi.yaml   | 11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git 
a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml 
b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
index cd0a42f35f24..6f421740b613 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
@@ -94,6 +94,9 @@ properties:
   - const: default
   - const: unwedge

+  power-domains:
+maxItems: 1
+
   ports:
 $ref: /schemas/graph.yaml#/properties/ports

@@ -141,16 +144,18 @@ examples:
 #include 
 #include 
 #include 
+#include 

 hdmi: hdmi@ff98 {
 compatible = "rockchip,rk3288-dw-hdmi";
 reg = <0xff98 0x2>;
-reg-io-width = <4>;
-ddc-i2c-bus = <>;
-rockchip,grf = <>;
 interrupts = ;
 clocks = <  PCLK_HDMI_CTRL>, < SCLK_HDMI_HDCP>;
 clock-names = "iahb", "isfr";
+ddc-i2c-bus = <>;
+power-domains = < RK3288_PD_VIO>;
+reg-io-width = <4>;
+rockchip,grf = <>;

 ports {
 #address-cells = <1>;
--
2.39.2