Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-02-12 Thread Byungchul Park
On Mon, Feb 12, 2024 at 04:16:41PM +0100, Thomas Gleixner wrote: > On Tue, Jan 30 2024 at 11:58, Byungchul Park wrote: > > On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: > >> On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: > >> > >> Why is lockdep in the subsystem prefix

Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-02-12 Thread Thomas Gleixner
On Tue, Jan 30 2024 at 11:58, Byungchul Park wrote: > On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: >> On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: >> >> Why is lockdep in the subsystem prefix here? You are changing the CPU >> hotplug (not hotplus) code, right? >> >> >

Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-29 Thread Byungchul Park
On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: > On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: > > Why is lockdep in the subsystem prefix here? You are changing the CPU > hotplug (not hotplus) code, right? > > > cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP

Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-28 Thread Byungchul Park
On Fri, Jan 26, 2024 at 06:30:02PM +0100, Thomas Gleixner wrote: > On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: > > Why is lockdep in the subsystem prefix here? You are changing the CPU > hotplug (not hotplus) code, right? I will fix the typo ;( Thank you. I referred to the commit

Re: [PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-26 Thread Thomas Gleixner
On Wed, Jan 24 2024 at 20:59, Byungchul Park wrote: Why is lockdep in the subsystem prefix here? You are changing the CPU hotplug (not hotplus) code, right? > cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was > introduced to make lockdep_assert_cpus_held() work in AP thread. >

[PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-24 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced,