Re: [PATCH v2] drm/meson: Fixes for drm_crtc_vblank_on/off support

2018-12-05 Thread Neil Armstrong
Hi Stable team, On 22/11/2018 17:01, Neil Armstrong wrote: > Since Linux 4.17, calls to drm_crtc_vblank_on/off are mandatory, and we get > a warning when ctrc is disabled : > " driver forgot to call drm_crtc_vblank_off()" > > But, the vsync IRQ was not totally disabled due the transient hardware

Re: [PATCH v2] drm/meson: Fixes for drm_crtc_vblank_on/off support

2018-11-24 Thread Lyude Paul
There are some typos according to dim checkpatch: 6421619a1655 (HEAD) drm/meson: Fixes for drm_crtc_vblank_on/off support -:48: WARNING:TYPO_SPELLING: 'occurence' may be misspelled - perhaps 'occurrence'? #48: The issue is that vblank need to be enabled in any occurence of : -:53:

[PATCH v2] drm/meson: Fixes for drm_crtc_vblank_on/off support

2018-11-22 Thread Neil Armstrong
Since Linux 4.17, calls to drm_crtc_vblank_on/off are mandatory, and we get a warning when ctrc is disabled : " driver forgot to call drm_crtc_vblank_off()" But, the vsync IRQ was not totally disabled due the transient hardware state and specific interrupt line, thus adding proper IRQ masking