Re: [Freedreno] [PATCH v2] drm/msm: Grab the GPU runtime in a6xx routines, not the GMU one

2022-06-09 Thread Akhil P Oommen
On 6/9/2022 11:42 PM, Rob Clark wrote: On Thu, Jun 9, 2022 at 11:04 AM Akhil P Oommen wrote: On 6/9/2022 10:17 PM, Douglas Anderson wrote: >From testing on sc7180-trogdor devices, reading the GMU registers needs the GMU clocks to be enabled. Those clocks get turned on in a6xx_gmu_resume().

Re: [PATCH v2] drm/msm: Grab the GPU runtime in a6xx routines, not the GMU one

2022-06-09 Thread Rob Clark
On Thu, Jun 9, 2022 at 11:04 AM Akhil P Oommen wrote: > > On 6/9/2022 10:17 PM, Douglas Anderson wrote: > > >From testing on sc7180-trogdor devices, reading the GMU registers > > needs the GMU clocks to be enabled. Those clocks get turned on in > > a6xx_gmu_resume(). Confusingly enough, that

Re: [PATCH v2] drm/msm: Grab the GPU runtime in a6xx routines, not the GMU one

2022-06-09 Thread Akhil P Oommen
On 6/9/2022 10:17 PM, Douglas Anderson wrote: >From testing on sc7180-trogdor devices, reading the GMU registers needs the GMU clocks to be enabled. Those clocks get turned on in a6xx_gmu_resume(). Confusingly enough, that function is called as a result of the runtime_pm of the GPU "struct

[PATCH v2] drm/msm: Grab the GPU runtime in a6xx routines, not the GMU one

2022-06-09 Thread Douglas Anderson
>From testing on sc7180-trogdor devices, reading the GMU registers needs the GMU clocks to be enabled. Those clocks get turned on in a6xx_gmu_resume(). Confusingly enough, that function is called as a result of the runtime_pm of the GPU "struct device", not the GMU "struct device". Let's grab a