Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-21 Thread Jonathan Liu
Hi Maxime, On 21 June 2017 at 18:41, Maxime Ripard wrote: > On Tue, Jun 13, 2017 at 09:53:31PM +1000, Jonathan Liu wrote: >> >> --- /dev/null >> >> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c >> >> @@ -0,0 +1,163 @@ >> >> +/* >> >> + * Copyright (C) 2017

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-21 Thread Maxime Ripard
On Tue, Jun 13, 2017 at 09:53:31PM +1000, Jonathan Liu wrote: > >> --- /dev/null > >> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c > >> @@ -0,0 +1,163 @@ > >> +/* > >> + * Copyright (C) 2017 Jonathan Liu > >> + * > >> + * Jonathan Liu > > > > Is it? > > I could add you to the

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-13 Thread Jonathan Liu
Hi Maxime, On 13 June 2017 at 21:15, Maxime Ripard wrote: > On Mon, Jun 12, 2017 at 03:52:35PM +1000, Jonathan Liu wrote: >> The drm_get_edid function should be used instead of drm_do_get_edid by >> exposing the DDC bus as an I2C adapter. Implement this for

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-13 Thread Maxime Ripard
On Mon, Jun 12, 2017 at 03:52:35PM +1000, Jonathan Liu wrote: > The drm_get_edid function should be used instead of drm_do_get_edid by > exposing the DDC bus as an I2C adapter. Implement this for A10s. > > Signed-off-by: Jonathan Liu Your commit log should explain *why* that

[PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-12 Thread Jonathan Liu
The drm_get_edid function should be used instead of drm_do_get_edid by exposing the DDC bus as an I2C adapter. Implement this for A10s. Signed-off-by: Jonathan Liu --- Changes for v2: - Rebased against Maxime's sunxi-drm/for-next branch - Fix up error paths in sun4i_hdmi_bind