Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-10 Thread J Lovejoy
> On Jul 8, 2019, at 1:57 PM, Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Qian Cai wrote: >> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: -/** +// SPDX-License-Identifier: MIT +/* * \file drm_memory.c * Memory management wrappers for DRM *

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-10 Thread J Lovejoy
> On Jul 8, 2019, at 1:57 PM, Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Qian Cai wrote: >> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: -/** +// SPDX-License-Identifier: MIT +/* * \file drm_memory.c * Memory management wrappers for DRM *

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-09 Thread J Lovejoy
> On Jul 8, 2019, at 1:57 PM, Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Qian Cai wrote: >> On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: -/** +// SPDX-License-Identifier: MIT +/* * \file drm_memory.c * Memory management wrappers for DRM *

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-08 Thread Thomas Gleixner
On Mon, 8 Jul 2019, Qian Cai wrote: > On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: > > > -/** > > > +// SPDX-License-Identifier: MIT > > > +/* > > >   * \file drm_memory.c > > >   * Memory management wrappers for DRM > > >   * > > > @@ -12,25 +13,6 @@ > > >   * Copyright 1999 Precision

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-08 Thread Qian Cai
On Mon, 2019-07-08 at 15:21 -0400, Ilia Mirkin wrote: > On Mon, Jul 8, 2019 at 2:06 PM Qian Cai wrote: > > > > The opening comment mark "/**" is reserved for kernel-doc comments, so > > it will generate a warning with "make W=1". > > > > drivers/gpu/drm/drm_memory.c:2: warning: Cannot

Re: [PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-08 Thread Ilia Mirkin
On Mon, Jul 8, 2019 at 2:06 PM Qian Cai wrote: > > The opening comment mark "/**" is reserved for kernel-doc comments, so > it will generate a warning with "make W=1". > > drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file > drm_memory.c > > Also, silence a checkpatch warning by

[PATCH v2] gpu/drm_memory: fix a few warnings

2019-07-08 Thread Qian Cai
The opening comment mark "/**" is reserved for kernel-doc comments, so it will generate a warning with "make W=1". drivers/gpu/drm/drm_memory.c:2: warning: Cannot understand * \file drm_memory.c Also, silence a checkpatch warning by adding a license identfiter where it indicates the MIT license