Re: [PATCH v2] libdrm: modetest: Allow selecting modes by index

2019-06-24 Thread John Stultz
On Mon, Jun 24, 2019 at 1:32 PM Ilia Mirkin wrote: > > Reviewed-by: Ilia Mirkin > > One minor comment below though: > > (Maybe let it sit on the list for a day in case anyone feels like > objecting strenuously.) Thanks so much for the review! > > @@ -829,6 +830,16 @@ connector_find_mode(struct

Re: [PATCH v2] libdrm: modetest: Allow selecting modes by index

2019-06-24 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin One minor comment below though: (Maybe let it sit on the list for a day in case anyone feels like objecting strenuously.) On Mon, Jun 24, 2019 at 4:27 PM John Stultz wrote: > > Often there are many similar modes, which cannot be selected > via modetest due to its

[PATCH v2] libdrm: modetest: Allow selecting modes by index

2019-06-24 Thread John Stultz
Often there are many similar modes, which cannot be selected via modetest due to its simple string matching. This change adds a mode index in the display output, which can then be used to specify a specific modeline to be set. Cc: Ilia Mirkin Cc: Rob Clark Cc: Bjorn Andersson Cc: Sumit Semwal