Re: [linux-sunxi] [PATCH v2 02/13] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS

2019-04-09 Thread Jagan Teki
Hi Ondřej Jirman, On Tue, Apr 9, 2019 at 5:01 PM Ondřej Jirman wrote: > > Hi Jagan, > > On Tue, Apr 09, 2019 at 02:08:18PM +0530, Jagan Teki wrote: > > Based on the conversation about using common dtsi from this thread[1], > > I'm commenting here to make show the diff directly on the nodes, > >

Re: [PATCH v2 02/13] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS

2019-04-09 Thread Maxime Ripard
On Tue, Apr 09, 2019 at 11:33:04AM +0200, Ondřej Jirman wrote: > On Tue, Apr 09, 2019 at 10:12:30AM +0200, Maxime Ripard wrote: > > Hi, > > > > On Tue, Apr 09, 2019 at 02:24:41AM +0200, meg...@megous.com wrote: > > > + { > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <_pins>; > > > > Since

Re: [linux-sunxi] [PATCH v2 02/13] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS

2019-04-09 Thread Maxime Ripard
On Tue, Apr 09, 2019 at 01:31:57PM +0200, Ondřej Jirman wrote: > Hi Jagan, > > On Tue, Apr 09, 2019 at 02:08:18PM +0530, Jagan Teki wrote: > > Based on the conversation about using common dtsi from this thread[1], > > I'm commenting here to make show the diff directly on the nodes, > > giving

Re: [linux-sunxi] [PATCH v2 02/13] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS

2019-04-09 Thread Jagan Teki
Based on the conversation about using common dtsi from this thread[1], I'm commenting here to make show the diff directly on the nodes, giving comments on each node so-that we can see the diff globally. On Tue, Apr 9, 2019 at 5:55 AM megous via linux-sunxi wrote: > > From: Ondrej Jirman > >

Re: [PATCH v2 02/13] arm64: dts: allwinner: h6: Add Orange Pi 3 DTS

2019-04-09 Thread Maxime Ripard
Hi, On Tue, Apr 09, 2019 at 02:24:41AM +0200, meg...@megous.com wrote: > + { > + pinctrl-names = "default"; > + pinctrl-0 = <_pins>; Since 5 minutes ago, that's now the default. > + { > + /* > + * Beware that this board will not automatically disconnect > + * VBUS from