Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

Hi Sam Am 25.04.22 um 19:46 schrieb Sam Ravnborg: Hi Thomas, On Mon, Apr 25, 2022 at 07:26:32PM +0200, Sam Ravnborg wrote: Hi Thomas, diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c index 6aaf6d0abf39..6924d489a289 100644 ---

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

Hi Thomas, On Mon, Apr 25, 2022 at 07:26:32PM +0200, Sam Ravnborg wrote: > Hi Thomas, > > > diff --git a/drivers/video/fbdev/core/fb_defio.c > > b/drivers/video/fbdev/core/fb_defio.c > > index 6aaf6d0abf39..6924d489a289 100644 > > --- a/drivers/video/fbdev/core/fb_defio.c > > +++

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

Hi Thomas, > diff --git a/drivers/video/fbdev/core/fb_defio.c > b/drivers/video/fbdev/core/fb_defio.c > index 6aaf6d0abf39..6924d489a289 100644 > --- a/drivers/video/fbdev/core/fb_defio.c > +++ b/drivers/video/fbdev/core/fb_defio.c > @@ -181,6 +181,7 @@ int fb_deferred_io_mmap(struct fb_info

Re: [PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on 0e7deff6446a4ba2c75f499a0bfa80cd6a15c129] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Decouple-deferred-I-O-from-struct-page/20220425-192955 base:

[PATCH v2 1/3] fbdev: Put mmap for deferred I/O into drivers

The fbdev mmap function fb_mmap() unconditionally overrides the driver's implementation if deferred I/O has been activated. This makes it hard to implement mmap with anything but a vmalloc()'ed software buffer. That is specifically a problem for DRM, where video memory is maintained by a memory