Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Geert Uytterhoeven
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 ---
> .../bindings/media/renesas,fcp.yaml | 56 +++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> deleted file mode 100644
> index 79c37395b396..
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Renesas R-Car Frame Compression Processor (FCP)
>
> -
> -The FCP is a companion module of video processing modules in the Renesas
> R-Car
> -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> -caching, and conversion of AXI transactions in order to reduce the memory
> -bandwidth.
> -
> -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> FCP
> -for FDP (FCPF). Their configuration and behaviour depend on the module they
> -are paired with. These DT bindings currently support the FCPV and FCPF.
> -
> - - compatible: Must be one or more of the following
> -
> - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> -
> - - reg: the register base and size for the device registers
> - - clocks: Reference to the functional clock
> -
> -Optional properties:
> - - power-domains : power-domain property defined with a power domain
> specifier
> -to respective power domain.
> -
> -
> -Device node example
>
> -
> - fcpvd1: fcp@fea2f000 {
> - compatible = "renesas,fcpv";
> - reg = <0 0xfea2f000 0 0x200>;
> - clocks = < CPG_MOD 602>;
> - power-domains = < R8A7795_PD_A3VP>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> new file mode 100644
> index ..9241bf3c5efc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Frame Compression Processor (FCP)
> +
> +maintainers:
> + - Laurent Pinchart
> +
> +description: |
> + The FCP is a companion module of video processing modules in the Renesas
> + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> + data caching, and conversion of AXI transactions in order to reduce the
> + memory bandwidth.
> +
> + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> + they are paired with. These DT bindings currently support the FCPV and
> FCPF.
> +
> +properties:
> + compatible:
> +enum:
> + - renesas,fcpv # FCP for VSP
> + - renesas,fcpf # FCP for FDP
> +
> + reg:
> +maxItems: 1
> +
> + clocks:
> +maxItems: 1
> +
> + power-domains:
> +maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
not? With this fixed,
Reviewed-by: Niklas Söderlund
> + - |
> +#include
> +#include
> +
> +fcp@fea2f000 {
> +compatible = "renesas,fcpv";
> +reg = <0xfea2f000 0x200>;
> +clocks = < CPG_MOD 602>;
> +power-domains = < R8A7795_PD_ALWAYS_ON>;
> +};
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 68f21d46614c..660ed6606de2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10700,7 +10700,7 @@ L:linux-me...@vger.kernel.org
> L: linux-renesas-...@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> F: drivers/media/platform/rcar-fcp.c
> F: include/media/rcar-fcp.h
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
Hi Niklas,
On Tue, Jun 30, 2020 at 10:49:18PM +0200, Niklas Söderlund wrote:
> On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> > Convert the Renesas R-Car FCP text binding to YAML.
> >
> > Signed-off-by: Laurent Pinchart
> > Reviewed-by: Geert Uytterhoeven
> > ---
> > Changes since v1:
> >
> > - Simplify comments on compatible strings
> > - Update MAINTAINERS
> > ---
> > .../devicetree/bindings/media/renesas,fcp.txt | 34 ---
> > .../bindings/media/renesas,fcp.yaml | 56 +++
> > MAINTAINERS | 2 +-
> > 3 files changed, 57 insertions(+), 35 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> > create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > deleted file mode 100644
> > index 79c37395b396..
> > --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +++ /dev/null
> > @@ -1,34 +0,0 @@
> > -Renesas R-Car Frame Compression Processor (FCP)
> >
> > -
> > -The FCP is a companion module of video processing modules in the Renesas
> > R-Car
> > -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> > -caching, and conversion of AXI transactions in order to reduce the memory
> > -bandwidth.
> > -
> > -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> > FCP
> > -for FDP (FCPF). Their configuration and behaviour depend on the module they
> > -are paired with. These DT bindings currently support the FCPV and FCPF.
> > -
> > - - compatible: Must be one or more of the following
> > -
> > - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> > - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> > -
> > - - reg: the register base and size for the device registers
> > - - clocks: Reference to the functional clock
> > -
> > -Optional properties:
> > - - power-domains : power-domain property defined with a power domain
> > specifier
> > - to respective power domain.
> > -
> > -
> > -Device node example
> >
> > -
> > - fcpvd1: fcp@fea2f000 {
> > - compatible = "renesas,fcpv";
> > - reg = <0 0xfea2f000 0 0x200>;
> > - clocks = < CPG_MOD 602>;
> > - power-domains = < R8A7795_PD_A3VP>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > new file mode 100644
> > index ..9241bf3c5efc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> > @@ -0,0 +1,56 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Renesas R-Car Frame Compression Processor (FCP)
> > +
> > +maintainers:
> > + - Laurent Pinchart
> > +
> > +description: |
> > + The FCP is a companion module of video processing modules in the Renesas
> > + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and
> > decompression,
> > + data caching, and conversion of AXI transactions in order to reduce the
> > + memory bandwidth.
> > +
> > + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV)
> > and
> > + FCP for FDP (FCPF). Their configuration and behaviour depend on the
> > module
> > + they are paired with. These DT bindings currently support the FCPV and
> > FCPF.
> > +
> > +properties:
> > + compatible:
> > +enum:
> > + - renesas,fcpv # FCP for VSP
> > + - renesas,fcpf # FCP for FDP
> > +
> > + reg:
> > +maxItems: 1
> > +
> > + clocks:
> > +maxItems: 1
> > +
> > + power-domains:
> > +maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + # R8A7790 (R-Car H2) VSP1-S
>
> Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
> not? With this fixed,
Absolutely. I don't know how it ended there. I'll fix this.
> Reviewed-by: Niklas Söderlund
>
> > + - |
> > +#include
> > +#include
> > +
> > +fcp@fea2f000 {
> > +compatible = "renesas,fcpv";
> > +reg = <0xfea2f000 0x200>;
> > +clocks = < CPG_MOD 602>;
> > +power-domains = < R8A7795_PD_ALWAYS_ON>;
> > +};
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 68f21d46614c..660ed6606de2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10700,7 +10700,7 @@ L: linux-me...@vger.kernel.org
> > L: linux-renesas-...@vger.kernel.org
> > S: Supported
> > T: git git://linuxtv.org/media_tree.git
> > -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> > +F:
[PATCH v2 1/8] dt-bindings: media: renesas, fcp: Convert binding to YAML
Convert the Renesas R-Car FCP text binding to YAML.
Signed-off-by: Laurent Pinchart
Reviewed-by: Geert Uytterhoeven
---
Changes since v1:
- Simplify comments on compatible strings
- Update MAINTAINERS
---
.../devicetree/bindings/media/renesas,fcp.txt | 34 ---
.../bindings/media/renesas,fcp.yaml | 56 +++
MAINTAINERS | 2 +-
3 files changed, 57 insertions(+), 35 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt
b/Documentation/devicetree/bindings/media/renesas,fcp.txt
deleted file mode 100644
index 79c37395b396..
--- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
+++ /dev/null
@@ -1,34 +0,0 @@
-Renesas R-Car Frame Compression Processor (FCP)
-
-The FCP is a companion module of video processing modules in the Renesas R-Car
-Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
-caching, and conversion of AXI transactions in order to reduce the memory
-bandwidth.
-
-There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
-for FDP (FCPF). Their configuration and behaviour depend on the module they
-are paired with. These DT bindings currently support the FCPV and FCPF.
-
- - compatible: Must be one or more of the following
-
- - "renesas,fcpv" for generic compatible 'FCP for VSP'
- - "renesas,fcpf" for generic compatible 'FCP for FDP'
-
- - reg: the register base and size for the device registers
- - clocks: Reference to the functional clock
-
-Optional properties:
- - power-domains : power-domain property defined with a power domain specifier
- to respective power domain.
-
-
-Device node example
-
- fcpvd1: fcp@fea2f000 {
- compatible = "renesas,fcpv";
- reg = <0 0xfea2f000 0 0x200>;
- clocks = < CPG_MOD 602>;
- power-domains = < R8A7795_PD_A3VP>;
- };
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml
b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
new file mode 100644
index ..9241bf3c5efc
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Frame Compression Processor (FCP)
+
+maintainers:
+ - Laurent Pinchart
+
+description: |
+ The FCP is a companion module of video processing modules in the Renesas
+ R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
+ data caching, and conversion of AXI transactions in order to reduce the
+ memory bandwidth.
+
+ There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
+ FCP for FDP (FCPF). Their configuration and behaviour depend on the module
+ they are paired with. These DT bindings currently support the FCPV and FCPF.
+
+properties:
+ compatible:
+enum:
+ - renesas,fcpv # FCP for VSP
+ - renesas,fcpf # FCP for FDP
+
+ reg:
+maxItems: 1
+
+ clocks:
+maxItems: 1
+
+ power-domains:
+maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+additionalProperties: false
+
+examples:
+ # R8A7790 (R-Car H2) VSP1-S
+ - |
+#include
+#include
+
+fcp@fea2f000 {
+compatible = "renesas,fcpv";
+reg = <0xfea2f000 0x200>;
+clocks = < CPG_MOD 602>;
+power-domains = < R8A7795_PD_ALWAYS_ON>;
+};
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 68f21d46614c..660ed6606de2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10700,7 +10700,7 @@ L: linux-me...@vger.kernel.org
L: linux-renesas-...@vger.kernel.org
S: Supported
T: git git://linuxtv.org/media_tree.git
-F: Documentation/devicetree/bindings/media/renesas,fcp.txt
+F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
F: drivers/media/platform/rcar-fcp.c
F: include/media/rcar-fcp.h
--
Regards,
Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
