Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Philipp Zabel
On Tue, 2019-08-27 at 15:20 +0200, Boris Brezillon wrote: > On Tue, 27 Aug 2019 14:51:20 +0200 > Philipp Zabel wrote: > > > [...] > > > > > I can do that if you like. Note that we are forwarding > > > > > the ->output_bus_cfg.fmt value to the IPU DI, not ->input_bus_cfg.fmt. > > > > > I just

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Boris Brezillon
On Tue, 27 Aug 2019 14:51:20 +0200 Philipp Zabel wrote: > [...] > > > > I can do that if you like. Note that we are forwarding > > > > the ->output_bus_cfg.fmt value to the IPU DI, not ->input_bus_cfg.fmt. > > > > I just assumed that input format wouldn't be used in the dummy bridge > > > >

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Philipp Zabel
On Tue, 2019-08-27 at 11:57 +0200, Boris Brezillon wrote: > On Tue, 27 Aug 2019 11:23:02 +0200 > Philipp Zabel wrote: > > On Tue, 2019-08-27 at 10:43 +0200, Boris Brezillon wrote: [...] > > Absolutely. This was just a cosmetic remark. I'm suggesting to put this > > branch below the other two, to

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Boris Brezillon
On Tue, 27 Aug 2019 11:23:02 +0200 Philipp Zabel wrote: > On Tue, 2019-08-27 at 10:43 +0200, Boris Brezillon wrote: > [...] > > > > +static void > > > > +imx_pd_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, > > > > +struct drm_bridge_state

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Philipp Zabel
On Tue, 2019-08-27 at 10:43 +0200, Boris Brezillon wrote: [...] > > > +static void > > > +imx_pd_bridge_atomic_get_output_bus_fmts(struct drm_bridge *bridge, > > > + struct drm_bridge_state *bridge_state, > > > + struct

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Boris Brezillon
On Tue, 27 Aug 2019 10:15:19 +0200 Philipp Zabel wrote: > Hi Boris, > > On Mon, 2019-08-26 at 17:26 +0200, Boris Brezillon wrote: > > Now that bridges can expose the bus format/flags they expect, we can > > use those instead of the relying on the display_info provided by the > > connector

Re: [PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-27 Thread Philipp Zabel
Hi Boris, On Mon, 2019-08-26 at 17:26 +0200, Boris Brezillon wrote: > Now that bridges can expose the bus format/flags they expect, we can > use those instead of the relying on the display_info provided by the > connector (which is only valid if the encoder is directly connected > to bridge

[PATCH v2 17/21] drm/imx: pd: Use bus format/flags provided by the bridge when available

2019-08-26 Thread Boris Brezillon
Now that bridges can expose the bus format/flags they expect, we can use those instead of the relying on the display_info provided by the connector (which is only valid if the encoder is directly connected to bridge element driving the panel/display). We also explicitly expose the bus formats