Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-03-01 Thread Jose Abreu
Hi Laurent, On 01-03-2017 11:09, Laurent Pinchart wrote: > Hi Jose, > > On Thursday 05 Jan 2017 15:06:49 Jose Abreu wrote: >> On 05-01-2017 12:29, Laurent Pinchart wrote: >>> On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: On 20-12-2016 11:45, Russell King - ARM Linux wrote: > On Tue,

Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-03-01 Thread Laurent Pinchart
Hi Jose, On Wednesday 01 Mar 2017 16:25:46 Jose Abreu wrote: > On 01-03-2017 11:09, Laurent Pinchart wrote: > > On Thursday 05 Jan 2017 15:06:49 Jose Abreu wrote: > >> On 05-01-2017 12:29, Laurent Pinchart wrote: > >>> On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: > On 20-12-2016 11:45, R

Re: [PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-03-01 Thread Laurent Pinchart
Hi Jose, On Thursday 05 Jan 2017 15:06:49 Jose Abreu wrote: > On 05-01-2017 12:29, Laurent Pinchart wrote: > > On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: > >> On 20-12-2016 11:45, Russell King - ARM Linux wrote: > >>> On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-06 Thread Laurent Pinchart
Hi Jose, On Friday 06 Jan 2017 10:07:03 Jose Abreu wrote: > Hi Laurent, > > Sorry for the delayed answer but I am quite busy at the moment. No worries, your help is really appreciated. > On 06-01-2017 01:48, Laurent Pinchart wrote: > > [snip] > > The TX_READY signal is documented in the

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-06 Thread Jose Abreu
Hi Laurent, Sorry for the delayed answer but I am quite busy at the moment. On 06-01-2017 01:48, Laurent Pinchart wrote: [snip] The TX_READY signal is documented in the i.MX6 datasheet as being a PHY output signal, but there seems to be no HDMI TX register from which its state

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-06 Thread Laurent Pinchart
Hi Jose, On Thursday 05 Jan 2017 17:33:58 Laurent Pinchart wrote: > On Thursday 05 Jan 2017 15:06:49 Jose Abreu wrote: > > On 05-01-2017 12:29, Laurent Pinchart wrote: > >> On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: > >>> On 20-12-2016 11:45, Russell King - ARM Linux wrote: > On Tue, D

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-05 Thread Laurent Pinchart
Hi Jose, On Thursday 05 Jan 2017 15:06:49 Jose Abreu wrote: > On 05-01-2017 12:29, Laurent Pinchart wrote: > > On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: > >> On 20-12-2016 11:45, Russell King - ARM Linux wrote: > >>> On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-05 Thread Jose Abreu
Hi Laurent, On 05-01-2017 12:29, Laurent Pinchart wrote: > Hi Jose, > > On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: >> On 20-12-2016 11:45, Russell King - ARM Linux wrote: >>> On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: Instead of spreading version-dependent PHY p

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2017-01-05 Thread Laurent Pinchart
Hi Jose, On Tuesday 20 Dec 2016 12:17:23 Jose Abreu wrote: > On 20-12-2016 11:45, Russell King - ARM Linux wrote: > > On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: > >> Instead of spreading version-dependent PHY power handling code around, > >> group it in two functions to powe

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2016-12-20 Thread Laurent Pinchart
Hi Russell, Thank you for the review. On Tuesday 20 Dec 2016 11:45:53 Russell King - ARM Linux wrote: > On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: > > Instead of spreading version-dependent PHY power handling code around, > > group it in two functions to power the PHY on an

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2016-12-20 Thread Jose Abreu
Hi Russell, On 20-12-2016 11:45, Russell King - ARM Linux wrote: > On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: >> Instead of spreading version-dependent PHY power handling code around, >> group it in two functions to power the PHY on and off and use them >> through the drive

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2016-12-20 Thread Russell King - ARM Linux
On Tue, Dec 20, 2016 at 03:33:48AM +0200, Laurent Pinchart wrote: > Instead of spreading version-dependent PHY power handling code around, > group it in two functions to power the PHY on and off and use them > through the driver. > > Powering off the PHY at the beginning of the setup phase is curr

[PATCH v2 17/29] drm: bridge: dw-hdmi: Refactor PHY power handling

2016-12-20 Thread Laurent Pinchart
Instead of spreading version-dependent PHY power handling code around, group it in two functions to power the PHY on and off and use them through the driver. Powering off the PHY at the beginning of the setup phase is currently split in two locations for first and second generation PHYs, group all