Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-03 Thread Rob Clark
On Wed, Nov 2, 2022 at 4:26 PM Dmitry Baryshkov wrote: > > On 02/11/2022 01:33, Rob Clark wrote: > > From: Rob Clark > > > > If the hangcheck timer expires, check if the fw's position in the > > cmdstream has advanced (changed) since last timer expiration, and > > allow it up to three additional

Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-02 Thread Dmitry Baryshkov
On 02/11/2022 01:33, Rob Clark wrote: From: Rob Clark If the hangcheck timer expires, check if the fw's position in the cmdstream has advanced (changed) since last timer expiration, and allow it up to three additional "extensions" to it's alotted time. The intention is to continue to catch

Re: [PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Hillf Danton
On 1 Nov 2022 15:33:10 -0700 Rob Clark > --- a/drivers/gpu/drm/msm/msm_gpu.c > +++ b/drivers/gpu/drm/msm/msm_gpu.c > @@ -500,6 +500,21 @@ static void hangcheck_timer_reset(struct msm_gpu *gpu) > round_jiffies_up(jiffies + > msecs_to_jiffies(priv->hangcheck_period))); > } >

[PATCH v2 2/2] drm/msm: Hangcheck progress detection

2022-11-01 Thread Rob Clark
From: Rob Clark If the hangcheck timer expires, check if the fw's position in the cmdstream has advanced (changed) since last timer expiration, and allow it up to three additional "extensions" to it's alotted time. The intention is to continue to catch "shader stuck in a loop" type hangs