Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-06 Thread Haneen Mohammed
On Fri, Aug 03, 2018 at 12:53:36PM -0400, Sean Paul wrote: > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > This patch implement the necessary functions to compute and add CRCs > > entries: > > > > - Implement the set_crc_source() callback. > > - Compute CRC using crc32 on th

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Fri, Aug 03, 2018 at 10:36:05PM +0300, Haneen Mohammed wrote: > On Fri, Aug 03, 2018 at 12:53:36PM -0400, Sean Paul wrote: > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > This patch implement the necessary functions to compute and add CRCs > > > entries: > > > > > > -

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Fri, Aug 03, 2018 at 03:10:57PM -0300, Gustavo Padovan wrote: > On Fri, Aug 03, 2018 at 12:42:15PM -0400, Sean Paul wrote: > > On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > > > Hi Haneen, > > > > > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > > T

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Gustavo Padovan
On Fri, Aug 03, 2018 at 12:42:15PM -0400, Sean Paul wrote: > On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > > Hi Haneen, > > > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > > This patch implement the necessary functions to compute and add CRCs > > > ent

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > This patch implement the necessary functions to compute and add CRCs > entries: > > - Implement the set_crc_source() callback. > - Compute CRC using crc32 on the visible part of the framebuffer. > - Use ordered workqueue per output

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-03 Thread Sean Paul
On Thu, Aug 02, 2018 at 08:09:51AM -0300, Gustavo Padovan wrote: > Hi Haneen, > > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > This patch implement the necessary functions to compute and add CRCs > > entries: > > > > - Implement the set_crc_source() callback. > > - Compute

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-02 Thread Gustavo Padovan
Hi Haneen, On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > This patch implement the necessary functions to compute and add CRCs > entries: > > - Implement the set_crc_source() callback. > - Compute CRC using crc32 on the visible part of the framebuffer. > - Use ordered workqueu

[PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-02 Thread Haneen Mohammed
This patch implement the necessary functions to compute and add CRCs entries: - Implement the set_crc_source() callback. - Compute CRC using crc32 on the visible part of the framebuffer. - Use ordered workqueue per output to compute and add CRC at the end of a vblank. - Use appropriate synchroni