Re: [PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

2019-07-22 Thread Sam Ravnborg
Hi Email. On Mon, Jul 22, 2019 at 04:46:08PM +0100, Emil Velikov wrote: > On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > > > VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from > > drm_os_linux.h. > > The copy is made so we can avoid the dependency on the legacy header. > > A more

Re: [PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

2019-07-22 Thread Emil Velikov
On Sat, 20 Jul 2019 at 09:46, Sam Ravnborg wrote: > > VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from > drm_os_linux.h. > The copy is made so we can avoid the dependency on the legacy header. > A more involved approach had been to introduce wait_event_* but for this > legacy driver the

[PATCH v2 2/4] drm/via: add VIA_WAIT_ON()

2019-07-20 Thread Sam Ravnborg
VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from drm_os_linux.h. The copy is made so we can avoid the dependency on the legacy header. A more involved approach had been to introduce wait_event_* but for this legacy driver the simpler and more safe approach with a copy of the macro was