Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 11:27 schreef Daniel Vetter: > On Tue, Jul 25, 2017 at 11:11 AM, Maarten Lankhorst > wrote: >> Op 25-07-17 om 10:23 schreef Daniel Vetter: >>> On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: /* - * Don't do an

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Daniel Vetter
On Tue, Jul 25, 2017 at 11:11 AM, Maarten Lankhorst wrote: > Op 25-07-17 om 10:23 schreef Daniel Vetter: >> On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: >>> /* >>> - * Don't do an async update if there is an outstanding commit

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Maarten Lankhorst
Op 25-07-17 om 10:23 schreef Daniel Vetter: > On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: >> Instead of assigning plane to __plane, iterate over plane >> which is the same thing. Simplify the check for n_planes != 1, >> at that point we know plane != NULL as well. >> >>

Re: [PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-25 Thread Daniel Vetter
On Wed, Jul 19, 2017 at 04:39:15PM +0200, Maarten Lankhorst wrote: > Instead of assigning plane to __plane, iterate over plane > which is the same thing. Simplify the check for n_planes != 1, > at that point we know plane != NULL as well. > > Rename obj_state to new_obj_state, and get rid of the

[PATCH v2 2/7] drm/atomic: Clean up drm_atomic_helper_async_check

2017-07-19 Thread Maarten Lankhorst
Instead of assigning plane to __plane, iterate over plane which is the same thing. Simplify the check for n_planes != 1, at that point we know plane != NULL as well. Rename obj_state to new_obj_state, and get rid of the bogus stuff. crtc->state->state is NEVER non-null, if it is, there is a bug.