Re: [PATCH v2 23/25] scsi: virtio: drop owner assignment

[Martin K. Petersen]

Krzysztof,

> virtio core already sets the .owner, so driver does not need to.

virtio_scsi looks OK to me.

Acked-by: Martin K. Petersen 

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH v2 23/25] scsi: virtio: drop owner assignment

[Stefan Hajnoczi]

On Sun, Mar 31, 2024 at 10:44:10AM +0200, Krzysztof Kozlowski wrote:
> virtio core already sets the .owner, so driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski 
> 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/scsi/virtio_scsi.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

[PATCH v2 23/25] scsi: virtio: drop owner assignment

[Krzysztof Kozlowski]

virtio core already sets the .owner, so driver does not need to.

Signed-off-by: Krzysztof Kozlowski 

---

Depends on the first patch.
---
 drivers/scsi/virtio_scsi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 617eb892f4ad..89ca26945721 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -1052,7 +1052,6 @@ static struct virtio_driver virtio_scsi_driver = {
.feature_table = features,
.feature_table_size = ARRAY_SIZE(features),
.driver.name = KBUILD_MODNAME,
-   .driver.owner = THIS_MODULE,
.id_table = id_table,
.probe = virtscsi_probe,
 #ifdef CONFIG_PM_SLEEP

-- 
2.34.1