[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-04 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 7:22 PM, Mark yao wrote: > On 2015年07月03日 17:58, Tomasz Figa wrote: >>Aren't the scl_modes for CbCr planes always the same as for Y plane? >>> >>> > >>> > >>> >No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12. >>> >so Y plane horizontal and

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Tomasz Figa
On Fri, Jul 3, 2015 at 6:17 PM, Mark yao wrote: >>> +static void _vop_cal_scl_fac(struct vop *vop, const struct vop_win_data >>> *win, >>> +uint32_t src_w, uint32_t src_h, uint32_t >>> dst_w, >>> +uint32_t dst_h, uint32_t pixel_format) >>>

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Mark yao
On 2015年07月03日 17:58, Tomasz Figa wrote: >>> >>Aren't the scl_modes for CbCr planes always the same as for Y plane? >> > >> > >> >No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12. >> >so Y plane horizontal and vertical is scale down. >> > >> >but src_w = 1920 / 2 = 960 <

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Mark yao
On 2015年07月03日 15:46, Tomasz Figa wrote: > Hi Mark, > > Please see my comments inline. > > On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: >> Win_full support 1/8 to 8 scale down/up engine, support >> all format scale. > [snip] > >> @@ -351,6 +412,15 @@ static inline void

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Tomasz Figa
Hi Mark, Please see my comments inline. On Fri, Jun 26, 2015 at 7:07 PM, Mark Yao wrote: > Win_full support 1/8 to 8 scale down/up engine, support > all format scale. [snip] > @@ -351,6 +412,15 @@ static inline void vop_mask_write_relaxed(struct vop > *vop, uint32_t offset, > } > }

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-07-03 Thread Russell King - ARM Linux
On Fri, Jul 03, 2015 at 06:58:44PM +0900, Tomasz Figa wrote: > On Fri, Jul 3, 2015 at 6:17 PM, Mark yao wrote: > >> Aren't the scl_modes for CbCr planes always the same as for Y plane? > > > > > > No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12. > > so Y plane horizontal and

[PATCH v2 3/5] drm/rockchip: vop: support plane scale

2015-06-26 Thread Mark Yao
Win_full support 1/8 to 8 scale down/up engine, support all format scale. Signed-off-by: Mark Yao --- Changes in v2: - Fix scale dest info. drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 389 ++- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 96 +++ 2 files