Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 05.38, skrev Noralf Trønnes: > > > Den 15.01.2019 00.26, skrev David Lechner: >> On 1/14/19 4:53 PM, Noralf Trønnes wrote: >>> >>> >>> Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: > On 1/14/19 10:13 AM, Noralf Trønnes wrote: >>

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 00.26, skrev David Lechner: > On 1/14/19 4:53 PM, Noralf Trønnes wrote: >> >> >> Den 14.01.2019 23.33, skrev David Lechner: >>> On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: > > I see that you have this call chain: >

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 4:53 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 15.01.2019 00.03, skrev David Lechner: > On 1/14/19 4:43 PM, Noralf Trønnes wrote: >> >> >> Den 14.01.2019 23.33, skrev David Lechner: >>> On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: > > I see that you have this call chain: >

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 4:43 PM, Noralf Trønnes wrote: Den 14.01.2019 23.33, skrev David Lechner: On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.33, skrev David Lechner: > On 1/14/19 3:50 PM, David Lechner wrote: >> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >>> >>> I see that you have this call chain: >>> st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). >>> >>> That doesn't look safe. The st7586

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.06, skrev David Lechner: > On 1/11/19 2:12 PM, Noralf Trønnes wrote: >> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty >> handler. All flushing will now happen in the pipe functions. >> >> Also enable the damage plane property for all except repaper which

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 23.33, skrev David Lechner: > On 1/14/19 3:50 PM, David Lechner wrote: >> On 1/14/19 10:13 AM, Noralf Trønnes wrote: >>> >>> I see that you have this call chain: >>> st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). >>> >>> That doesn't look safe. The st7586

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 3:50 PM, David Lechner wrote: On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufsize =

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do full updates. ili9225: This change made

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread David Lechner
On 1/14/19 10:13 AM, Noralf Trønnes wrote: I see that you have this call chain: st7586_pipe_enable() -> mipi_dbi_enable_flush() -> mipi_dbi_fb_dirty(). That doesn't look safe. The st7586 driver allocates a tx_buf with size: size_t bufsize = (mode->vdisplay + 2) / 3 * mode->hdisplay;

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 16.00, skrev Noralf Trønnes: > > > Den 14.01.2019 03.15, skrev David Lechner: >> On 1/13/19 3:19 PM, David Lechner wrote: >>> On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-14 Thread Noralf Trønnes
Den 14.01.2019 03.15, skrev David Lechner: > On 1/13/19 3:19 PM, David Lechner wrote: >> On 1/11/19 2:12 PM, Noralf Trønnes wrote: >>> This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty >>> handler. All flushing will now happen in the pipe functions. >>> >>> Also enable the

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-13 Thread David Lechner
On 1/13/19 3:19 PM, David Lechner wrote: On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do

Re: [PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-13 Thread David Lechner
On 1/11/19 2:12 PM, Noralf Trønnes wrote: This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do full updates. ili9225: This change made

[PATCH v2 4/5] drm/tinydrm: Use damage helper for dirtyfb

2019-01-11 Thread Noralf Trønnes
This switches to drm_atomic_helper_dirtyfb() as the framebuffer dirty handler. All flushing will now happen in the pipe functions. Also enable the damage plane property for all except repaper which can only do full updates. ili9225: This change made ili9225_init() equal to mipi_dbi_init() so use