Re: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-09-09 Thread Linus Walleij
Hi Paul, just a drive-by comment: On Sat, Aug 22, 2020 at 6:33 PM Paul Cercueil wrote: > + gpiod_set_value_cansleep(priv->reset_gpiod, 0); > + usleep_range(20, 1000); > + gpiod_set_value_cansleep(priv->reset_gpiod, 1); This implies that the reset line is active low. I would

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-09-08 Thread Neil Armstrong
On 07/09/2020 14:57, Paul Cercueil wrote: > > > Le dim. 30 août 2020 à 22:28, Sam Ravnborg a écrit : >> Hi Laurent. >> >>>  > >>>  > Please read the cover letter, it explains why it's done this way. The >>>  > whole point of this patchset is to merge DSI and DBI frameworks in a >>>  > way that

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-09-07 Thread Paul Cercueil
Le dim. 30 août 2020 à 22:28, Sam Ravnborg a écrit : Hi Laurent. > > Please read the cover letter, it explains why it's done this way. The > whole point of this patchset is to merge DSI and DBI frameworks in a > way that can be maintained. I think this proves the point that the

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-31 Thread Paul Cercueil
Hi Leon, Le dim. 30 août 2020 à 16:36, 何小龙 (Leon He) a écrit : +struct ili9341 { + struct drm_panel panel; + struct mipi_dsi_device *dsi; + const struct ili9341_pdata *pdata; + + struct gpio_desc*reset_gpiod; + u32 rotation; +}; + Hi Paul, you

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Sam Ravnborg
Hi Laurent. > > > > Please read the cover letter, it explains why it's done this way. The > > whole point of this patchset is to merge DSI and DBI frameworks in a > > way that can be maintained. > > I think this proves the point that the proposed naming is confusing. At > least a rename would

Re: 答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Laurent Pinchart
Hi Paul, On Sun, Aug 30, 2020 at 06:48:12PM +0200, Paul Cercueil wrote: > Le dim. 30 août 2020 à 16:36, 何小龙 (Leon He) a écrit : > >> +struct ili9341 { > >> + struct drm_panel panel; > >> + struct mipi_dsi_device *dsi; > >> + const struct ili9341_pdata *pdata; > >> + > >> +

答复: [PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-30 Thread Leon He
> +struct ili9341 { > + struct drm_panel panel; > + struct mipi_dsi_device *dsi; > + const struct ili9341_pdata *pdata; > + > + struct gpio_desc*reset_gpiod; > + u32 rotation; > +}; > + Hi Paul, you put the mipi_dsi_device inside the struct. I think it maybe

[PATCH v2 6/6] drm/panel: Add Ilitek ILI9341 DBI panel driver

2020-08-24 Thread Paul Cercueil
This driver is for the Ilitek ILI9341 based YX240QV29-T 2.4" 240x320 TFT LCD panel from Adafruit. v2: - Remove custom handling of backlight - Call drm_panel_disable() / drm_panel_unprepare() on module exit - drm_panel_add() is a void function now Signed-off-by: Paul Cercueil ---