Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-10 Thread Daniel Vetter
On Tue, Jan 09, 2018 at 09:09:32PM -0600, David Lechner wrote: > On 01/09/2018 08:05 AM, Noralf Trønnes wrote: > > > > Den 09.01.2018 11.08, skrev Daniel Vetter: > > > On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: > > > > On 01/07/2018 11:44 AM, Noralf Trønnes wrote: > > > > >

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread David Lechner
On 01/09/2018 08:05 AM, Noralf Trønnes wrote: Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread Noralf Trønnes
Den 09.01.2018 11.08, skrev Daniel Vetter: On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-09 Thread Daniel Vetter
On Mon, Jan 08, 2018 at 07:46:27PM -0600, David Lechner wrote: > On 01/07/2018 11:44 AM, Noralf Trønnes wrote: > > Embed the mode in tinydrm_connector instead of doing an devm_ allocation. > > Remove unnecessary use of ret variable at the end of > > tinydrm_display_pipe_init(). > > > >

Re: [PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-08 Thread David Lechner
On 01/07/2018 11:44 AM, Noralf Trønnes wrote: Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes --- Reviewed-by: David Lechner

[PATCH v2 6/6] drm/tinydrm: Embed the mode in tinydrm_connector

2018-01-07 Thread Noralf Trønnes
Embed the mode in tinydrm_connector instead of doing an devm_ allocation. Remove unnecessary use of ret variable at the end of tinydrm_display_pipe_init(). Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 +++-- 1