Re: [PATCH v2 6/8] drm/etnaviv: provide MMU context to etnaviv_gem_mapping_get

2019-04-25 Thread Philipp Zabel
On Wed, 2019-04-17 at 15:50 +0200, Lucas Stach wrote:
> In preparation to having a context per process, etnaviv_gem_mapping_get
> should not use the current GPU context, but needs to be told which
> context to use.
> 
> Signed-off-by: Lucas Stach 

Reviewed-by: Philipp Zabel 

regards
Philipp
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 6/8] drm/etnaviv: provide MMU context to etnaviv_gem_mapping_get

2019-04-17 Thread Lucas Stach
In preparation to having a context per process, etnaviv_gem_mapping_get
should not use the current GPU context, but needs to be told which
context to use.

Signed-off-by: Lucas Stach 
---
 drivers/gpu/drm/etnaviv/etnaviv_gem.c| 20 
 drivers/gpu/drm/etnaviv/etnaviv_gem.h|  3 ++-
 drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c |  2 +-
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c 
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 76c26d8f8d63..e4f07c9682f7 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -259,7 +259,8 @@ void etnaviv_gem_mapping_unreference(struct 
etnaviv_vram_mapping *mapping)
 }
 
 struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
-   struct drm_gem_object *obj, struct etnaviv_gpu *gpu)
+   struct drm_gem_object *obj, struct etnaviv_gpu *gpu,
+   struct etnaviv_iommu_context *mmu)
 {
struct etnaviv_gem_object *etnaviv_obj = to_etnaviv_bo(obj);
struct etnaviv_vram_mapping *mapping;
@@ -267,7 +268,7 @@ struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
int ret = 0;
 
mutex_lock(_obj->lock);
-   mapping = etnaviv_gem_get_vram_mapping(etnaviv_obj, gpu->mmu);
+   mapping = etnaviv_gem_get_vram_mapping(etnaviv_obj, mmu);
if (mapping) {
/*
 * Holding the object lock prevents the use count changing
@@ -276,12 +277,12 @@ struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
 * the MMU owns this mapping to close this race.
 */
if (mapping->use == 0) {
-   mutex_lock(>mmu->lock);
-   if (mapping->context == gpu->mmu)
+   mutex_lock(>lock);
+   if (mapping->context == mmu)
mapping->use += 1;
else
mapping = NULL;
-   mutex_unlock(>mmu->lock);
+   mutex_unlock(>lock);
if (mapping)
goto out;
} else {
@@ -314,10 +315,11 @@ struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
list_del(>obj_node);
}
 
-   mapping->context = gpu->mmu;
+   etnaviv_iommu_context_get(mmu);
+   mapping->context = mmu;
mapping->use = 1;
 
-   ret = etnaviv_iommu_map_gem(gpu->mmu, etnaviv_obj, gpu->memory_base,
+   ret = etnaviv_iommu_map_gem(mmu, etnaviv_obj, gpu->memory_base,
mapping);
if (ret < 0)
kfree(mapping);
@@ -540,8 +542,10 @@ void etnaviv_gem_free_object(struct drm_gem_object *obj)
 
WARN_ON(mapping->use);
 
-   if (context)
+   if (context) {
etnaviv_iommu_unmap_gem(context, mapping);
+   etnaviv_iommu_context_put(context);
+   }
 
list_del(>obj_node);
kfree(mapping);
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.h 
b/drivers/gpu/drm/etnaviv/etnaviv_gem.h
index cf94f0b24584..79a211f5ac5f 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.h
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.h
@@ -123,7 +123,8 @@ struct page **etnaviv_gem_get_pages(struct 
etnaviv_gem_object *obj);
 void etnaviv_gem_put_pages(struct etnaviv_gem_object *obj);
 
 struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
-   struct drm_gem_object *obj, struct etnaviv_gpu *gpu);
+   struct drm_gem_object *obj, struct etnaviv_gpu *gpu,
+   struct etnaviv_iommu_context *mmu);
 void etnaviv_gem_mapping_reference(struct etnaviv_vram_mapping *mapping);
 void etnaviv_gem_mapping_unreference(struct etnaviv_vram_mapping *mapping);
 
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c 
b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index f5b3dfa312b7..9442196a3d51 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -229,7 +229,7 @@ static int submit_pin_objects(struct etnaviv_gem_submit 
*submit)
struct etnaviv_vram_mapping *mapping;
 
mapping = etnaviv_gem_mapping_get(_obj->base,
- submit->gpu);
+ submit->gpu, 
submit->gpu->mmu);
if (IS_ERR(mapping)) {
ret = PTR_ERR(mapping);
break;
-- 
2.20.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel