Re: [PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-16 Thread Linus Walleij
Hi Stephan, I fixed up the patch according to your comments, this remains: On Mon, Dec 16, 2019 at 6:55 PM Stephan Gerhold wrote: > In general I was wondering if we could benefit from using something like > the regmap_update_bits() helper to avoid having to write this manually > all the time.

Re: [PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-16 Thread Stephan Gerhold
Hi Linus, Thanks for keeping this patch updated! I think it is about time that we get this patch applied - it gets increasingly larger and more complex and therefore difficult to review. Most of it looks fine to me, I just have a few notes below: On Tue, Dec 10, 2019 at 11:48:57PM +0100, Linus

[PATCH v3] drm/mcde: Some fixes to handling video mode

2019-12-10 Thread Linus Walleij
The video DSI mode had not really been tested. These fixes makes it more likely to work on real hardware: - Put the active width (x width) in the right bits and the VSA (vertical sync active) in the right bits (those were swapped). - Calculate the packet sizes in bytes as in the vendor driver,

[PATCH v3] drm/mcde: Some fixes to handling video mode

2019-10-01 Thread Linus Walleij
The video DSI mode had not really been tested. These fixes makes it more likely to work on real hardware: - Put the active width (x width) in the right bits and the VSA (vertical sync active) in the right bits (those were swapped). - Calculate the packet sizes in bytes as in the vendor driver,