Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-19 Thread Maxime Ripard
On Mon, Dec 17, 2018 at 10:20:39PM +0200, sakari.ai...@iki.fi wrote: > Hi Maxime, > > On Mon, Dec 17, 2018 at 04:49:21PM +0100, Maxime Ripard wrote: > > Hi Sakari, > > > > Thanks for your feedback. > > > > On Thu, Dec 13, 2018 at 10:49:28PM +0200, sakari.ai...@iki.fi wrote: > > > > + /** >

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-17 Thread sakari . ailus
Hi Maxime, On Mon, Dec 17, 2018 at 04:49:21PM +0100, Maxime Ripard wrote: > Hi Sakari, > > Thanks for your feedback. > > On Thu, Dec 13, 2018 at 10:49:28PM +0200, sakari.ai...@iki.fi wrote: > > > + /** > > > + * @lanes: > > > + * > > > + * Number of active data lanes used for the transmission

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-17 Thread Maxime Ripard
Hi Sakari, Thanks for your feedback. On Thu, Dec 13, 2018 at 10:49:28PM +0200, sakari.ai...@iki.fi wrote: > > + /** > > +* @lanes: > > +* > > +* Number of active data lanes used for the transmissions. > > Could you add that these are the first "lanes" number of lanes from what > ar

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
Hi Maxime, One more small note. On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: ... > + /** > + * @wakeup: > + * > + * Time, in picoseconds, that a transmitter drives a Mark-1 > + * state prior to a Stop state in order to initiate an exit > + * from U

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
On Thu, Dec 13, 2018 at 10:54:28PM +0200, sakari.ai...@iki.fi wrote: > Hi Maxime, > > One more small note. > > On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > > ... > > > + /** > > +* @wakeup: > > +* > > +* Time, in picoseconds, that a transmitter drives a Mark-1

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
Hi Maxime, On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > Now that we have some infrastructure for it, allow the MIPI D-PHY phy's to > be configured through the generic functions through a custom structure > added to the generic union. > > The parameters added here are the ones

[PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-07 Thread Maxime Ripard
Now that we have some infrastructure for it, allow the MIPI D-PHY phy's to be configured through the generic functions through a custom structure added to the generic union. The parameters added here are the ones defined in the MIPI D-PHY spec, plus the number of lanes in use. The current set of p