Hi Jacopo,
Thank you for the patch.
On Sun, Aug 25, 2019 at 03:51:45PM +0200, Jacopo Mondi wrote:
> Add CMM units to Renesas R-Car M3-N device tree and reference them from
> the Display Unit they are connected to.
>
> Signed-off-by: Jacopo Mondi
Apart from the issue with compatible string as pointed out for patch
03/14,
Reviewed-by: Laurent Pinchart
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 25 +++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 4ae163220f60..8cf0d049203d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -2320,6 +2320,30 @@
> resets = <&cpg 611>;
> };
>
> + cmm0: cmm@fea4 {
> + compatible = "renesas,cmm-r8a77965";
> + reg = <0 0xfea4 0 0x1000>;
> + clocks = <&cpg CPG_MOD 711>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 711>;
> + };
> +
> + cmm1: cmm@fea5 {
> + compatible = "renesas,cmm-r8a77965";
> + reg = <0 0xfea5 0 0x1000>;
> + clocks = <&cpg CPG_MOD 710>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 710>;
> + };
> +
> + cmm3: cmm@fea7 {
> + compatible = "renesas,cmm-r8a77965";
> + reg = <0 0xfea7 0 0x1000>;
> + clocks = <&cpg CPG_MOD 708>;
> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
> + resets = <&cpg 708>;
> + };
> +
> csi20: csi2@fea8 {
> compatible = "renesas,r8a77965-csi2";
> reg = <0 0xfea8 0 0x1>;
> @@ -2470,6 +2494,7 @@
> status = "disabled";
>
> vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>;
> + cmms = <&cmm0 &cmm1 &cmm3>;
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
