Re: [PATCH v3 1/2] drm/vc4: Fix NULL pointer dereference in the async update path

On Thu, 15 Nov 2018 08:25:48 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > vc4_plane_atomic_async_update() calls vc4_plane_atomic_check() > > which in turn calls vc4_plane_setup_clipping_and_scaling(), and since > > commit 58a6a36fe8e0 ("drm/vc4: Use > > drm_atomic_helper_check_plane

Re: [PATCH v3 1/2] drm/vc4: Fix NULL pointer dereference in the async update path

Boris Brezillon writes: > vc4_plane_atomic_async_update() calls vc4_plane_atomic_check() > which in turn calls vc4_plane_setup_clipping_and_scaling(), and since > commit 58a6a36fe8e0 ("drm/vc4: Use > drm_atomic_helper_check_plane_state() to simplify the logic"), this > function accesses plane_sta

[PATCH v3 1/2] drm/vc4: Fix NULL pointer dereference in the async update path

vc4_plane_atomic_async_update() calls vc4_plane_atomic_check() which in turn calls vc4_plane_setup_clipping_and_scaling(), and since commit 58a6a36fe8e0 ("drm/vc4: Use drm_atomic_helper_check_plane_state() to simplify the logic"), this function accesses plane_state->state which will be NULL when ca