Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-12-04 Thread Uwe Kleine-König
On Tue, Nov 28, 2023 at 07:54:31PM +, sa...@kapsi.fi wrote: > November 28, 2023 at 6:49 PM, "Uwe Kleine-König" > mailto:u.kleine-koe...@pengutronix.de?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > > wrote: > > > > > On Fri, Nov 03, 2023 at 09:58:07AM +0200,

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-28 Thread jyri . sarha
November 2, 2023 at 6:56 PM, "Uwe Kleine-König" mailto:u.kleine-koe...@pengutronix.de?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-28 Thread sarha
November 28, 2023 at 6:49 PM, "Uwe Kleine-König" mailto:u.kleine-koe...@pengutronix.de?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > wrote: > > On Fri, Nov 03, 2023 at 09:58:07AM +0200, Tomi Valkeinen wrote: > > > > > On 02/11/2023 18:56, Uwe Kleine-König wrote:

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-28 Thread Uwe Kleine-König
On Fri, Nov 03, 2023 at 09:58:07AM +0200, Tomi Valkeinen wrote: > On 02/11/2023 18:56, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returning an error code.

Re: [PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-03 Thread Tomi Valkeinen
On 02/11/2023 18:56, Uwe Kleine-König wrote: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in

[PATCH v3 16/16] drm/tilcdc: Convert to platform remove callback returning void

2023-11-02 Thread Uwe Kleine-König
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to