Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Laurentiu Palcu
Hi Philipp, On Fri, Mar 06, 2020 at 11:20:51AM +0100, Philipp Zabel wrote: > Hi Laurentiu, > > On Fri, 2020-03-06 at 11:58 +0200, Laurentiu Palcu wrote: > > On Wed, Feb 26, 2020 at 02:19:11PM +0100, Lucas Stach wrote: > [...] > > > > +/* This function will be called from interrupt context. */ >

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Philipp Zabel
Hi Laurentiu, On Fri, 2020-03-06 at 11:58 +0200, Laurentiu Palcu wrote: > On Wed, Feb 26, 2020 at 02:19:11PM +0100, Lucas Stach wrote: [...] > > > +/* This function will be called from interrupt context. */ > > > +void dcss_scaler_write_sclctrl(struct dcss_scaler *scl) > > > +{ > > > + int chnum;

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-03-06 Thread Laurentiu Palcu
Hi Lucas, Thanks for the in-depth review. I will send a new version shortly, with most of your sugestions implemented. Had to run some regression tests on the new version though, hence my late reply... :/ There are several answers to your questions in-line. Didn't reply to all of them though as

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-02-26 Thread Lucas Stach
Hi Laurentiu, again a day later than promised, but here we go with some more in-depth comments. Apologies if I missed something, my metal bandwidth was pretty exhausted by the time I made my was to the scaler code. :) On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This adds initial

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-02-25 Thread Laurentiu Palcu
Hi Lucas, Thanks for taking some time to look over this series. On Mon, Feb 24, 2020 at 06:27:25PM +0100, Lucas Stach wrote: > Hi Laurentiu, > > just a first drive-by comment, more in-depth review tomorrow. > > On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > > This adds initial

Re: [PATCH v3 2/4] drm/imx: Add initial support for DCSS on iMX8MQ

2020-02-24 Thread Lucas Stach
Hi Laurentiu, just a first drive-by comment, more in-depth review tomorrow. On Fr, 2019-12-06 at 11:52 +0200, Laurentiu Palcu wrote: > This adds initial support for iMX8MQ's Display Controller Subsystem (DCSS). > Some of its capabilities include: > * 4K@60fps; > * HDR10; > * one graphics and