Re: [PATCH v3 2/6] ARM: dts: exynos: Add clean name of compatible.

2017-09-08 Thread Robin Murphy 
On 08/09/17 07:02, Hoegeun Kwon wrote:
> Exynos 5250 and 5420 have different hardware rotation limits. However,
> currently it uses only one compatible - "exynos5-gsc". Since we have
> to distinguish between these two, we add different compatible.
> 
> Signed-off-by: Hoegeun Kwon 
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 8 
>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 8dbeb87..bf08101 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -637,7 +637,7 @@
>   };
>  
>   gsc_0:  gsc@13e0 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5250-gsc";

These should be the other way round - the most specific compatible
should come first, then the more general fallback afterwards.

(and similarly in all cases below)

Robin.

>   reg = <0x13e0 0x1000>;
>   interrupts = ;
>   power-domains = <_gsc>;
> @@ -647,7 +647,7 @@
>   };
>  
>   gsc_1:  gsc@13e1 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5250-gsc";
>   reg = <0x13e1 0x1000>;
>   interrupts = ;
>   power-domains = <_gsc>;
> @@ -657,7 +657,7 @@
>   };
>  
>   gsc_2:  gsc@13e2 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5250-gsc";
>   reg = <0x13e2 0x1000>;
>   interrupts = ;
>   power-domains = <_gsc>;
> @@ -667,7 +667,7 @@
>   };
>  
>   gsc_3:  gsc@13e3 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5250-gsc";
>   reg = <0x13e3 0x1000>;
>   interrupts = ;
>   power-domains = <_gsc>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
> b/arch/arm/boot/dts/exynos5420.dtsi
> index 02d2f89..86afe77 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -658,7 +658,7 @@
>   };
>  
>   gsc_0: video-scaler@13e0 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5420-gsc";
>   reg = <0x13e0 0x1000>;
>   interrupts = ;
>   clocks = < CLK_GSCL0>;
> @@ -668,7 +668,7 @@
>   };
>  
>   gsc_1: video-scaler@13e1 {
> - compatible = "samsung,exynos5-gsc";
> + compatible = "samsung,exynos5-gsc", 
> "samsung,exynos5420-gsc";
>   reg = <0x13e1 0x1000>;
>   interrupts = ;
>   clocks = < CLK_GSCL1>;
> 

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v3 2/6] ARM: dts: exynos: Add clean name of compatible.

2017-09-08 Thread Hoegeun Kwon 
Exynos 5250 and 5420 have different hardware rotation limits. However,
currently it uses only one compatible - "exynos5-gsc". Since we have
to distinguish between these two, we add different compatible.

Signed-off-by: Hoegeun Kwon 
---
 arch/arm/boot/dts/exynos5250.dtsi | 8 
 arch/arm/boot/dts/exynos5420.dtsi | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
b/arch/arm/boot/dts/exynos5250.dtsi
index 8dbeb87..bf08101 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -637,7 +637,7 @@
};
 
gsc_0:  gsc@13e0 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5250-gsc";
reg = <0x13e0 0x1000>;
interrupts = ;
power-domains = <_gsc>;
@@ -647,7 +647,7 @@
};
 
gsc_1:  gsc@13e1 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5250-gsc";
reg = <0x13e1 0x1000>;
interrupts = ;
power-domains = <_gsc>;
@@ -657,7 +657,7 @@
};
 
gsc_2:  gsc@13e2 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5250-gsc";
reg = <0x13e2 0x1000>;
interrupts = ;
power-domains = <_gsc>;
@@ -667,7 +667,7 @@
};
 
gsc_3:  gsc@13e3 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5250-gsc";
reg = <0x13e3 0x1000>;
interrupts = ;
power-domains = <_gsc>;
diff --git a/arch/arm/boot/dts/exynos5420.dtsi 
b/arch/arm/boot/dts/exynos5420.dtsi
index 02d2f89..86afe77 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -658,7 +658,7 @@
};
 
gsc_0: video-scaler@13e0 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5420-gsc";
reg = <0x13e0 0x1000>;
interrupts = ;
clocks = < CLK_GSCL0>;
@@ -668,7 +668,7 @@
};
 
gsc_1: video-scaler@13e1 {
-   compatible = "samsung,exynos5-gsc";
+   compatible = "samsung,exynos5-gsc", 
"samsung,exynos5420-gsc";
reg = <0x13e1 0x1000>;
interrupts = ;
clocks = < CLK_GSCL1>;
-- 
1.9.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel