Re: [PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-13 Thread Daniel Vetter
On Wed, Jul 12, 2017 at 09:47:27AM +0200, Peter Rosin wrote: > On 2017-07-12 09:03, Daniel Vetter wrote: > > On Tue, Jul 11, 2017 at 02:12:26PM +0200, Peter Rosin wrote: > >> On 2017-07-11 10:10, Daniel Vetter wrote: > >>> Tiny nit you might want to improve (since you need to respin for my naming

Re: [PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-12 Thread Peter Rosin
On 2017-07-12 09:03, Daniel Vetter wrote: > On Tue, Jul 11, 2017 at 02:12:26PM +0200, Peter Rosin wrote: >> On 2017-07-11 10:10, Daniel Vetter wrote: >>> Tiny nit you might want to improve (since you need to respin for my naming >>> bikeshed of the property_replace_blob function anyway):

Re: [PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-12 Thread Daniel Vetter
On Tue, Jul 11, 2017 at 02:12:26PM +0200, Peter Rosin wrote: > On 2017-07-11 10:10, Daniel Vetter wrote: > > On Thu, Jul 06, 2017 at 02:20:37PM +0200, Peter Rosin wrote: > >> The legacy path implements setcmap in terms of crtc .gamma_set. > >> > >> The atomic path implements setcmap by directly

Re: [PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-11 Thread Peter Rosin
On 2017-07-11 10:10, Daniel Vetter wrote: > On Thu, Jul 06, 2017 at 02:20:37PM +0200, Peter Rosin wrote: >> The legacy path implements setcmap in terms of crtc .gamma_set. >> >> The atomic path implements setcmap by directly updating the crtc gamma_lut >> property. >> >> This has a couple of

Re: [PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-11 Thread Daniel Vetter
On Thu, Jul 06, 2017 at 02:20:37PM +0200, Peter Rosin wrote: > The legacy path implements setcmap in terms of crtc .gamma_set. > > The atomic path implements setcmap by directly updating the crtc gamma_lut > property. > > This has a couple of benefits: > - it makes the redundant fb helpers

[PATCH v4 03/14] drm/fb-helper: separate the fb_setcmap helper into atomic and legacy paths

2017-07-06 Thread Peter Rosin
The legacy path implements setcmap in terms of crtc .gamma_set. The atomic path implements setcmap by directly updating the crtc gamma_lut property. This has a couple of benefits: - it makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get completely obsolete. They are now unused