Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-06-06 Thread Linus Walleij
On Sun, Jun 4, 2023 at 5:44 PM Christophe JAILLET wrote: > > + /* Asserts RESET */ > > + gpiod_set_value(md->reset, 1); > > Hi, > > should this also be done in the probe if mipid_detect() fails? It's a nice bonus but surely not urgent or necessary. > If yes, please also look at [1],

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-06-05 Thread Guenter Roeck
Hi, On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > The Nokia 770 is using GPIOs from the global numberspace on the > CBUS node to pass down to the LCD controller. This regresses when we > let the OMAP GPIO driver use dynamic GPIO base. > ... > > Suggested-by: Dmitry Torokhov

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-06-04 Thread Christophe JAILLET
Le 08/05/2023 à 23:20, Linus Walleij a écrit : The Nokia 770 is using GPIOs from the global numberspace on the CBUS node to pass down to the LCD controller. This regresses when we let the OMAP GPIO driver use dynamic GPIO base. The Nokia 770 now has dynamic allocation of IRQ numbers, so this

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-17 Thread Linus Walleij
On Wed, May 17, 2023 at 10:39 PM Aaro Koskinen wrote: > When tested w/gpio-descriptors-omap branch, the touchscreen probe fails: > > [2.378540] SPI driver ads7846 has no spi_device_id for ti,tsc2046 > [2.391906] SPI driver ads7846 has no spi_device_id for ti,ads7843 > [2.405029] SPI

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-17 Thread Linus Walleij
On Wed, May 17, 2023 at 9:59 PM Aaro Koskinen wrote: > This does not compile as nokia770_ads7846_props is declared twice, > and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing. H I think we should probably update omap1_defconfig to enable all the OMAP1 drivers so we have

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-17 Thread Aaro Koskinen
Hi, On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > The CBUS also has the ADS7846 touchscreen attached. Not sure what this comment means. CBUS is for Retu/Tahvo, and touchscreen is SPI. When tested w/gpio-descriptors-omap branch, the touchscreen probe fails: [2.378540] SPI

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-17 Thread Aaro Koskinen
Hi, This does not compile as nokia770_ads7846_props is declared twice, and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing. On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = { > +

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-08 Thread Dmitry Torokhov
On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > The Nokia 770 is using GPIOs from the global numberspace on the > CBUS node to pass down to the LCD controller. This regresses when we > let the OMAP GPIO driver use dynamic GPIO base. > > The Nokia 770 now has dynamic allocation of

[PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

2023-05-08 Thread Linus Walleij
The Nokia 770 is using GPIOs from the global numberspace on the CBUS node to pass down to the LCD controller. This regresses when we let the OMAP GPIO driver use dynamic GPIO base. The Nokia 770 now has dynamic allocation of IRQ numbers, so this needs to be fixed for it to work. As this is the