Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 20:29 schrieb Grodzovsky, Andrey: > On 4/17/19 2:01 PM, Koenig, Christian wrote: >> Am 17.04.19 um 19:59 schrieb Christian König: >>> Am 17.04.19 um 19:53 schrieb Grodzovsky, Andrey: On 4/17/19 1:17 PM, Christian König wrote: > I can't review this patch, since I'm one of

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Grodzovsky, Andrey
On 4/17/19 2:01 PM, Koenig, Christian wrote: > Am 17.04.19 um 19:59 schrieb Christian König: >> Am 17.04.19 um 19:53 schrieb Grodzovsky, Andrey: >>> On 4/17/19 1:17 PM, Christian König wrote: I can't review this patch, since I'm one of the authors of it, but in general your changes look

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Koenig, Christian
Am 17.04.19 um 19:59 schrieb Christian König: > Am 17.04.19 um 19:53 schrieb Grodzovsky, Andrey: >> On 4/17/19 1:17 PM, Christian König wrote: >>> I can't review this patch, since I'm one of the authors of it, but in >>> general your changes look good to me now. >>> >>> For patch #5 I think it

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Christian König
Am 17.04.19 um 19:53 schrieb Grodzovsky, Andrey: On 4/17/19 1:17 PM, Christian König wrote: I can't review this patch, since I'm one of the authors of it, but in general your changes look good to me now. For patch #5 I think it might be cleaner if we move incrementing of the hw_rq_count while

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Grodzovsky, Andrey
On 4/17/19 1:17 PM, Christian König wrote: > I can't review this patch, since I'm one of the authors of it, but in > general your changes look good to me now. > > For patch #5 I think it might be cleaner if we move incrementing of > the hw_rq_count while starting the scheduler again. But the

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Christian König
I can't review this patch, since I'm one of the authors of it, but in general your changes look good to me now. For patch #5 I think it might be cleaner if we move incrementing of the hw_rq_count while starting the scheduler again. Regards, Christian. Am 17.04.19 um 16:36 schrieb

Re: [PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-17 Thread Grodzovsky, Andrey
Ping on this patch and patch 5. The rest already RBed. Andrey On 4/16/19 2:23 PM, Andrey Grodzovsky wrote: > From: Christian König > > We now destroy finished jobs from the worker thread to make sure that > we never destroy a job currently in timeout processing. > By this we avoid holding lock

[PATCH v4 3/5] drm/scheduler: rework job destruction

2019-04-16 Thread Andrey Grodzovsky
From: Christian König We now destroy finished jobs from the worker thread to make sure that we never destroy a job currently in timeout processing. By this we avoid holding lock around ring mirror list in drm_sched_stop which should solve a deadlock reported by a user. v2: Remove unused