Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Andrew Davis
On 1/9/23 5:47 AM, Jacek Lawrynowicz wrote: Hi, On 06.01.2023 14:29, Stanislaw Gruszka wrote: Hi On Thu, Jan 05, 2023 at 12:46:51PM -0600, Andrew Davis wrote: On 12/8/22 5:07 AM, Jacek Lawrynowicz wrote: Adds four types of GEM-based BOs for the VPU: - shmem - userptr Do you have

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Jacek Lawrynowicz
Hi, On 06.01.2023 19:25, Daniel Vetter wrote: > On Fri, 6 Jan 2023 at 14:23, Stanislaw Gruszka > wrote: >> >> On Fri, Jan 06, 2023 at 11:50:05AM +0100, Daniel Vetter wrote: >>> On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote: Adds four types of GEM-based BOs for the VPU:

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-09 Thread Jacek Lawrynowicz
Hi, On 06.01.2023 14:29, Stanislaw Gruszka wrote: > Hi > > On Thu, Jan 05, 2023 at 12:46:51PM -0600, Andrew Davis wrote: >> On 12/8/22 5:07 AM, Jacek Lawrynowicz wrote: >>> Adds four types of GEM-based BOs for the VPU: >>>- shmem >>>- userptr >> >> Do you have some specific need for

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-06 Thread Daniel Vetter
On Fri, 6 Jan 2023 at 14:23, Stanislaw Gruszka wrote: > > On Fri, Jan 06, 2023 at 11:50:05AM +0100, Daniel Vetter wrote: > > On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote: > > > Adds four types of GEM-based BOs for the VPU: > > > - shmem > > > - userptr > > > - internal

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-06 Thread Stanislaw Gruszka
Hi On Thu, Jan 05, 2023 at 12:46:51PM -0600, Andrew Davis wrote: > On 12/8/22 5:07 AM, Jacek Lawrynowicz wrote: > > Adds four types of GEM-based BOs for the VPU: > >- shmem > >- userptr > > Do you have some specific need for userptr that would not > be covered by prime import + heaps?

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-06 Thread Stanislaw Gruszka
On Fri, Jan 06, 2023 at 11:50:05AM +0100, Daniel Vetter wrote: > On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote: > > Adds four types of GEM-based BOs for the VPU: > > - shmem > > - userptr > > - internal > > Uh what do you need this for? Usually the way we do these is

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-06 Thread Daniel Vetter
On Thu, Dec 08, 2022 at 12:07:29PM +0100, Jacek Lawrynowicz wrote: > Adds four types of GEM-based BOs for the VPU: > - shmem > - userptr > - internal Uh what do you need this for? Usually the way we do these is just alloce a normal bo, and then pin them. Also, gem shmem helpers should be

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2023-01-05 Thread Andrew Davis
On 12/8/22 5:07 AM, Jacek Lawrynowicz wrote: Adds four types of GEM-based BOs for the VPU: - shmem - userptr Do you have some specific need for userptr that would not be covered by prime import + heaps? I'm just trying to get a feel for the typical use-cases for these. Andrew -

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-19 Thread Jacek Lawrynowicz
Hi, On 18.12.2022 11:23, Oded Gabbay wrote: > On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz > wrote: >> Adds four types of GEM-based BOs for the VPU: >> - shmem >> - userptr >> - internal >> - prime >> >> All types are implemented as struct ivpu_bo, based on >> struct drm_gem_object.

Re: [PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-18 Thread Oded Gabbay
On Thu, Dec 8, 2022 at 1:08 PM Jacek Lawrynowicz wrote: > > Adds four types of GEM-based BOs for the VPU: > - shmem > - userptr > - internal > - prime > > All types are implemented as struct ivpu_bo, based on > struct drm_gem_object. VPU address is allocated when buffer is created >

[PATCH v4 3/7] accel/ivpu: Add GEM buffer object management

2022-12-08 Thread Jacek Lawrynowicz
Adds four types of GEM-based BOs for the VPU: - shmem - userptr - internal - prime All types are implemented as struct ivpu_bo, based on struct drm_gem_object. VPU address is allocated when buffer is created except for imported prime buffers that allocate it in BO_INFO IOCTL due to