Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

[Sebastian Reichel]

Hi,

On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote:
> Simplify the code by moving code from _dsicm_enable_te() into
> dsicm_power_on().
> 
> Signed-off-by: Tomi Valkeinen 
> ---

Reviewed-by: Sebastian Reichel 

-- Sebastian

>  drivers/gpu/drm/panel/panel-dsi-cm.c | 23 ---
>  1 file changed, 4 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c 
> b/drivers/gpu/drm/panel/panel-dsi-cm.c
> index cb0d27a38555..59e8e6b18e97 100644
> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
> @@ -69,8 +69,6 @@ static inline struct panel_drv_data *panel_to_ddata(struct 
> drm_panel *panel)
>   return container_of(panel, struct panel_drv_data, panel);
>  }
>  
> -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable);
> -
>  static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable)
>  {
>   struct backlight_device *backlight;
> @@ -314,10 +312,13 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
>   if (r)
>   goto err;
>  
> - r = _dsicm_enable_te(ddata, true);
> + r = mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
>   if (r)
>   goto err;
>  
> + /* possible panel bug */
> + msleep(100);
> +
>   ddata->enabled = true;
>  
>   if (!ddata->intro_printed) {
> @@ -418,22 +419,6 @@ static int dsicm_disable(struct drm_panel *panel)
>   return r;
>  }
>  
> -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable)
> -{
> - struct mipi_dsi_device *dsi = ddata->dsi;
> - int r;
> -
> - if (enable)
> - r = mipi_dsi_dcs_set_tear_on(dsi, 
> MIPI_DSI_DCS_TEAR_MODE_VBLANK);
> - else
> - r = mipi_dsi_dcs_set_tear_off(dsi);
> -
> - /* possible panel bug */
> - msleep(100);
> -
> - return r;
> -}
> -
>  static int dsicm_get_modes(struct drm_panel *panel,
>  struct drm_connector *connector)
>  {
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 


signature.asc
Description: PGP signature
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

[Laurent Pinchart]

Hi Tomi,

Thank you for the patch.

On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote:
> Simplify the code by moving code from _dsicm_enable_te() into
> dsicm_power_on().
> 
> Signed-off-by: Tomi Valkeinen 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/panel/panel-dsi-cm.c | 23 ---
>  1 file changed, 4 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c 
> b/drivers/gpu/drm/panel/panel-dsi-cm.c
> index cb0d27a38555..59e8e6b18e97 100644
> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
> @@ -69,8 +69,6 @@ static inline struct panel_drv_data *panel_to_ddata(struct 
> drm_panel *panel)
>   return container_of(panel, struct panel_drv_data, panel);
>  }
>  
> -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable);
> -
>  static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable)
>  {
>   struct backlight_device *backlight;
> @@ -314,10 +312,13 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
>   if (r)
>   goto err;
>  
> - r = _dsicm_enable_te(ddata, true);
> + r = mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
>   if (r)
>   goto err;
>  
> + /* possible panel bug */
> + msleep(100);
> +
>   ddata->enabled = true;
>  
>   if (!ddata->intro_printed) {
> @@ -418,22 +419,6 @@ static int dsicm_disable(struct drm_panel *panel)
>   return r;
>  }
>  
> -static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable)
> -{
> - struct mipi_dsi_device *dsi = ddata->dsi;
> - int r;
> -
> - if (enable)
> - r = mipi_dsi_dcs_set_tear_on(dsi, 
> MIPI_DSI_DCS_TEAR_MODE_VBLANK);
> - else
> - r = mipi_dsi_dcs_set_tear_off(dsi);
> -
> - /* possible panel bug */
> - msleep(100);
> -
> - return r;
> -}
> -
>  static int dsicm_get_modes(struct drm_panel *panel,
>  struct drm_connector *connector)
>  {

-- 
Regards,

Laurent Pinchart
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

[Sam Ravnborg]

On Tue, Nov 24, 2020 at 02:45:14PM +0200, Tomi Valkeinen wrote:
> Simplify the code by moving code from _dsicm_enable_te() into
> dsicm_power_on().
> 
> Signed-off-by: Tomi Valkeinen 
Reviewed-by: Sam Ravnborg 
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 56/80] drm/panel: panel-dsi-cm: cleanup tear enable

[Tomi Valkeinen]

Simplify the code by moving code from _dsicm_enable_te() into
dsicm_power_on().

Signed-off-by: Tomi Valkeinen 
---
 drivers/gpu/drm/panel/panel-dsi-cm.c | 23 ---
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c 
b/drivers/gpu/drm/panel/panel-dsi-cm.c
index cb0d27a38555..59e8e6b18e97 100644
--- a/drivers/gpu/drm/panel/panel-dsi-cm.c
+++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
@@ -69,8 +69,6 @@ static inline struct panel_drv_data *panel_to_ddata(struct 
drm_panel *panel)
return container_of(panel, struct panel_drv_data, panel);
 }
 
-static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable);
-
 static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable)
 {
struct backlight_device *backlight;
@@ -314,10 +312,13 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
if (r)
goto err;
 
-   r = _dsicm_enable_te(ddata, true);
+   r = mipi_dsi_dcs_set_tear_on(ddata->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
if (r)
goto err;
 
+   /* possible panel bug */
+   msleep(100);
+
ddata->enabled = true;
 
if (!ddata->intro_printed) {
@@ -418,22 +419,6 @@ static int dsicm_disable(struct drm_panel *panel)
return r;
 }
 
-static int _dsicm_enable_te(struct panel_drv_data *ddata, bool enable)
-{
-   struct mipi_dsi_device *dsi = ddata->dsi;
-   int r;
-
-   if (enable)
-   r = mipi_dsi_dcs_set_tear_on(dsi, 
MIPI_DSI_DCS_TEAR_MODE_VBLANK);
-   else
-   r = mipi_dsi_dcs_set_tear_off(dsi);
-
-   /* possible panel bug */
-   msleep(100);
-
-   return r;
-}
-
 static int dsicm_get_modes(struct drm_panel *panel,
   struct drm_connector *connector)
 {
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel