Re: [PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes
On 01/12/2020 02:27, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: >> Drop unneeded includes. >> >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c >> b/drivers/gpu/drm/panel/panel-dsi-cm.c >> index ec87b785871f..91ed8237a1c2 100644 >> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c >> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c >> @@ -9,12 +9,7 @@ >> #include >> #include >> #include >> -#include > > This could go to the patch that moves TE handling to the code. True. >> #include >> -#include > > I'd keep module.h as you use macros it defines, and we shouldn't depend > in indirect includes. Ok. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes
Hi Tomi, Thank you for the patch. On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c > b/drivers/gpu/drm/panel/panel-dsi-cm.c > index ec87b785871f..91ed8237a1c2 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -9,12 +9,7 @@ > #include > #include > #include > -#include This could go to the patch that moves TE handling to the code. > #include > -#include I'd keep module.h as you use macros it defines, and we shouldn't depend in indirect includes. Reviewed-by: Laurent Pinchart > -#include > -#include > -#include > #include > > #include -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes
On Tue, Nov 24, 2020 at 02:45:28PM +0200, Tomi Valkeinen wrote: > Drop unneeded includes. > > Signed-off-by: Tomi Valkeinen I trust the compiler here. Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c > b/drivers/gpu/drm/panel/panel-dsi-cm.c > index ec87b785871f..91ed8237a1c2 100644 > --- a/drivers/gpu/drm/panel/panel-dsi-cm.c > +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c > @@ -9,12 +9,7 @@ > #include > #include > #include > -#include > #include > -#include > -#include > -#include > -#include > #include > > #include > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v4 70/80] drm/panel: panel-dsi-cm: drop unneeded includes
Drop unneeded includes. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/panel/panel-dsi-cm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel/panel-dsi-cm.c index ec87b785871f..91ed8237a1c2 100644 --- a/drivers/gpu/drm/panel/panel-dsi-cm.c +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c @@ -9,12 +9,7 @@ #include #include #include -#include #include -#include -#include -#include -#include #include #include -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
