Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-07-02 Thread Jonathan Liu
Hi Chen-Yu and Maxime, On 30 June 2017 at 13:16, Chen-Yu Tsai wrote: > On Fri, Jun 30, 2017 at 6:22 AM, Jonathan Liu wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> wrote: >>> On Wed, Jun 28, 2017 at

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-07-02 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 19:58, Jonathan Liu wrote: > Hi Maxime, > > On 30 June 2017 at 19:34, Maxime Ripard > wrote: >> Hi, >> >> On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: >>> Hi Maxime, >>> >>> On 30 June 2017 at

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-07-02 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 19:34, Maxime Ripard wrote: > Hi, > > On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> wrote: >> > On Wed, Jun 28, 2017

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-07-02 Thread Chen-Yu Tsai
On Fri, Jun 30, 2017 at 6:22 AM, Jonathan Liu wrote: > Hi Maxime, > > On 30 June 2017 at 01:56, Maxime Ripard > wrote: >> On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: >>> >> + u32 int_status; >>> >> + u32 fifo_status;

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-30 Thread Maxime Ripard
On Sat, Jul 01, 2017 at 12:14:44AM +1000, Jonathan Liu wrote: > Hi Chen-Yu and Maxime, > > On 30 June 2017 at 13:16, Chen-Yu Tsai wrote: > > On Fri, Jun 30, 2017 at 6:22 AM, Jonathan Liu wrote: > >> Hi Maxime, > >> > >> On 30 June 2017 at 01:56, Maxime Ripard >

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-30 Thread Maxime Ripard
Hi, On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: > Hi Maxime, > > On 30 June 2017 at 01:56, Maxime Ripard > wrote: > > On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: > >> >> + u32 int_status; > >> >> + u32 fifo_status; >

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-29 Thread Jonathan Liu
Hi Maxime, On 30 June 2017 at 01:56, Maxime Ripard wrote: > On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: >> >> + u32 int_status; >> >> + u32 fifo_status; >> >> + /* Read needs empty flag unset, write needs full flag unset */ >> >> +

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-29 Thread Maxime Ripard
On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: > >> + u32 int_status; > >> + u32 fifo_status; > >> + /* Read needs empty flag unset, write needs full flag unset */ > >> + u32 flag = read ? SUN4I_HDMI_DDC_FIFO_STATUS_EMPTY : > >> +

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
Hi Maxime, On 28 June 2017 at 19:20, Maxime Ripard wrote: > On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: >> +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ >> + SUN4I_HDMI_DDC_INT_STATUS_ILLEGAL_FIFO_OPERATION | \ >> +

[PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Jonathan Liu
The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: "As in the general case the DDC bus is accessible by the kernel at the I2C level, drivers must make all reasonable efforts to expose it as an I2C adapter and use drm_get_edid() instead of abusing this function." Exposing

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread kbuild test robot
Hi Jonathan, [auto build test WARNING on next-20170627] [cannot apply to v4.12-rc7 v4.12-rc6 v4.12-rc5 v4.12-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

2017-06-28 Thread Maxime Ripard
On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: > +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ > + SUN4I_HDMI_DDC_INT_STATUS_ILLEGAL_FIFO_OPERATION | \ > + SUN4I_HDMI_DDC_INT_STATUS_DDC_RX_FIFO_UNDERFLOW | \ > + SUN4I_HDMI_DDC_INT_STATUS_DDC_TX_FIFO_OVERFLOW | \ > +