RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-20 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 11:30:48AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API On Wed, Jun 14, 2023 at 08:21

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-19 Thread Biju Das
Hi All, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > > Without of_node, devm_clk_get() and friends falls back to registered > > > clkdevs. So you could call clk_register_clkdev() from within the > > > PMIC driver, and can

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-16 Thread Wolfram Sang
> > Without of_node, devm_clk_get() and friends falls back to registered > > clkdevs. So you could call clk_register_clkdev() from within the > > PMIC driver, and can keep on using devm_clk_get_optional() in the > > ISL1208 driver. > > Seriously, how many hacks are we piling ? :-) For this

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-15 Thread Laurent Pinchart
On Wed, Jun 14, 2023 at 11:30:48AM +, Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 08:21:38AM +, Biju Das wrote: >> > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device AP

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-15 Thread Laurent Pinchart
On Thu, Jun 15, 2023 at 10:07:39AM +0200, Geert Uytterhoeven wrote: > On Wed, Jun 14, 2023 at 9:53 AM Geert Uytterhoeven > wrote: > > On Tue, Jun 13, 2023 at 6:11 PM Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-15 Thread Geert Uytterhoeven
Hi Biju, On Wed, Jun 14, 2023 at 1:04 PM Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 10:21 AM Biju Das > > wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_dev

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-15 Thread Geert Uytterhoeven
Hi Biju, On Wed, Jun 14, 2023 at 9:53 AM Geert Uytterhoeven wrote: > On Tue, Jun 13, 2023 at 6:11 PM Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > On Tue, Jun 13, 2023 at 12:45 PM Biju Das > > > wrote: > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 08:21:38AM +, Biju Das wrote: > > Hi Laurent, > > > > Thanks for the feedback. > > > > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, Jun 14, 2023 at 10:21 AM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > &g

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Laurent Pinchart
On Wed, Jun 14, 2023 at 08:21:38AM +, Biju Das wrote: > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > On Tue, Jun 13, 2023 at 07:31:46PM +, Biju Das wrote: > > > >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Geert Uytterhoeven
Hi Biju, On Wed, Jun 14, 2023 at 10:21 AM Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Tue, Jun 13, 2023 at 07:31:46PM +, Biju Das wrote: > > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_anci

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Tue, Jun 13, 2023 at 07:31:46PM +, Biju Das wrote: > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API > >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Laurent Pinchart
On Tue, Jun 13, 2023 at 07:31:46PM +, Biju Das wrote: > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Tue, Jun 13, 2023 at 6:11 PM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Geert Uytterhoeven
Hi Biju, On Tue, Jun 13, 2023 at 6:11 PM Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Tue, Jun 13, 2023 at 12:45 PM Biju Das > > wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_dev

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi Wolfram, > > &g

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi e

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Tue, Jun 13, 2023 at 12:45 PM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Geert Uytterhoeven
Hi Biju, On Tue, Jun 13, 2023 at 12:45 PM Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > > > Perhaps we should first think through what an ancillary devic

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > > Perhaps we should first think through what an ancillary device > >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > Perhaps we should first think through what an ancillary device really > > is. My understanding is that it is used to talk to secondary addresses > > of a multi-address I2C slave device. > > As I mentioned somewhere before,

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi everyone, > > > Perhaps we should first think through what an ancillary device really > > is. My understanding is that it is used to talk to secondary

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Wolfram Sang
Hi everyone, > Perhaps we should first think through what an ancillary device really > is. My understanding is that it is used to talk to secondary addresses > of a multi-address I2C slave device. As I mentioned somewhere before, this is not the case. Ancillary devices are when one *driver*

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
Hi Geert, On Mon, Jun 12, 2023 at 03:08:46PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 12, 2023 at 2:54 PM Laurent Pinchart wrote: > > On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device AP

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jun 12, 2023 at 2:54 PM Laurent Pinchart wrote: > On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Wolfram, On Mon, Jun 12, 2023 at 2:48 PM Wolfram Sang wrote: > > > Would this binding allow to not use the RTC if the second reg is > > > missing? What are the advantages of not enabling RTC? Saving power? > > > > It doesn't work if there is no clock? > > Maybe I am confusing something now,

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
On Mon, Jun 12, 2023 at 02:44:33PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote: > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > > Hi All, > > > > > > How do we proceed here between [1] and [2]? > > > > > > DT-Maintainers suggestion: >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; > > re

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
Hi Biju, On Mon, Jun 12, 2023 at 12:42:33PM +, Biju Das wrote: > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Wolfram Sang
Hi Geert, > > Would this binding allow to not use the RTC if the second reg is > > missing? What are the advantages of not enabling RTC? Saving power? > > It doesn't work if there is no clock? Maybe I am confusing something now, but if the RTC _needs_ to be enabled, then why we don't do it

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote: > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > Hi All, > > > > How do we proceed here between [1] and [2]? > > > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible =

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, Jun 12, 2023 at 09:53:02AM +, Biju Das wrote: > > Hi All, > > > > How do we proceed here between [1] and [2]? > > > > DT-Mainta

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Geert Uytterhoeven
Hi Wolfram, Laurent, On Mon, Jun 12, 2023 at 2:36 PM Wolfram Sang wrote: > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; If you go for separate nodes: "renesas,raa215300-pmic". > > reg = <0x12>, <0x6f>; > > reg-names =

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Wolfram Sang
Hi Biju, > DT-Maintainers suggestion: > [1] > raa215300: pmic@12 { > compatible = "renesas,raa215300"; > reg = <0x12>, <0x6f>; > reg-names = "main", "rtc"; > > clocks = <>; > clock-names = "xin"; > /* Add Optional shared IRQ resource and share it to child and

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Laurent Pinchart
Alexandre > > Belloni ; Jonas Karlman ; > > Jernej Skrabec ; Uwe Kleine-König > koe...@pengutronix.de>; Corey Minyard ; Marek Behún > > ; Jiasheng Jiang ; Antonio Borneo > > ; Abhinav Kumar ; > > Ahmad Fatoum ; dri-devel@lists.freedesktop.org; > > linu

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
nyard ; Marek Behún > ; Jiasheng Jiang ; Antonio Borneo > ; Abhinav Kumar ; > Ahmad Fatoum ; dri-devel@lists.freedesktop.org; > linux-...@vger.kernel.org; linux-me...@vger.kernel.org; Geert > Uytterhoeven ; Fabrizio Castro > ; linux-renesas-...@vger.kernel.org; Mar

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Thu, Jun 08, 2023 at 11:00:19AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Laurent Pinchart
Hi Biju, On Thu, Jun 08, 2023 at 11:00:19AM +, Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Thu, Jun 08, 2023 at 06:41:35AM +, Biju Das wrote: > > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_anci

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Thu, Jun 08, 2023 at 06:41:35AM +, Biju Das wrote: > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device >

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Laurent Pinchart
Hi Biju, On Thu, Jun 08, 2023 at 06:41:35AM +, Biju Das wrote: > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API > > > > > > Hi all, >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > Hi Wolfram, > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi all, > > > > sorry for not being able to c

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-07 Thread Biju Das
Hi Wolfram, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi all, > > sorry for not being able to chime in earlier. > > > In Biju's particular use case, the i2c device responds to two > > addresses, which is the standard i2

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-07 Thread Wolfram Sang
Hi all, sorry for not being able to chime in earlier. > In Biju's particular use case, the i2c device responds to two addresses, > which is the standard i2c ancillary use case. However, what's special Not quite. ancillary is used when a *driver* needs to take care of two addresses. We already

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-05 Thread Wolfram Sang
> Wolfram: time to chime in ;-) I'll have a look this week. signature.asc Description: PGP signature

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-02 Thread Biju Das
Hi All, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > On Wed, May 31, 2023 at 12:53:18PM

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, May 31, 2023 at 2:53 PM Biju Das > wrote: > > > > * This function creates and returns an I2C ancillary client whose > > &g

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, May 31, 2023 at 12:53:18PM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API On Wed,

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Geert Uytterhoeven
Hi Biju, On Wed, May 31, 2023 at 2:53 PM Biju Das wrote: > > > * This function creates and returns an I2C ancillary client whose I2C > > > address > > > * is retrieved from the platform firmware based on the given slave > > > name. If > > > * aux_device_name is not NULL, the ancillary's device

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Geert Uytterhoeven
> > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > > > API > > > > > And why do you need this ? > > > > > > > > As per Krzysztof [2], > > > > > > > > The DT schema allows m

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Laurent Pinchart
Hi Geert, On Wed, May 31, 2023 at 02:51:48PM +0200, Geert Uytterhoeven wrote: > On Wed, May 31, 2023 at 10:59 AM Laurent Pinchart wrote: > > On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device A

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Laurent Pinchart
On Wed, May 31, 2023 at 12:53:18PM +, Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, May 31, 2023 at 09:34:06AM +, Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device &g

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Geert Uytterhoeven
Hi Laurent, On Wed, May 31, 2023 at 10:59 AM Laurent Pinchart wrote: > On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > And why do you need this ? > > > > As per Krz

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, May 31, 2023 at 09:34:06AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Laurent Pinchart
Hi Biju, On Wed, May 31, 2023 at 09:34:06AM +, Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_anci

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Laurent Pinchart
Hi Biju, On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, May 22, 2023 at 11:18:39AM +0100, Biju Das wrote: > > > Renesas PMIC RAA215300 exposes two separate i2c devices, one for

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > Thank you for the patch. > > On Mon, May 22, 2023 at 11:18:39AM +0100, Biju Das wrote: > > Renesas PMIC RAA215300 exposes tw

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-29 Thread Laurent Pinchart
Hi Biju, Thank you for the patch. On Mon, May 22, 2023 at 11:18:39AM +0100, Biju Das wrote: > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main > device and another for rtc device. > > Enhance i2c_new_ancillary_device() to instantiate a real device. Doesn't it already

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-25 Thread Geert Uytterhoeven
On Mon, May 22, 2023 at 12:19 PM Biju Das wrote: > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main > device and another for rtc device. > > Enhance i2c_new_ancillary_device() to instantiate a real device. > (eg: Instantiate rtc device from PMIC driver) > > Added helper

Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-23 Thread Hans Verkuil
On 22/05/2023 12:18, Biju Das wrote: > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main > device and another for rtc device. > > Enhance i2c_new_ancillary_device() to instantiate a real device. > (eg: Instantiate rtc device from PMIC driver) > > Added helper function

[PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-22 Thread Biju Das
Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main device and another for rtc device. Enhance i2c_new_ancillary_device() to instantiate a real device. (eg: Instantiate rtc device from PMIC driver) Added helper function __i2c_new_dummy_device to share the code between