Re: [PATCH v5 05/11] drm: Add helpers to kick off self refresh mode in drivers

2019-06-12 Thread Sean Paul
On Tue, Jun 11, 2019 at 10:56:45PM +0200, Sam Ravnborg wrote: > Hi Sean. > > Small things here and there. Did not stare at this long enough to > understand the code, but added some feedback anyway. Thanks for the comments, Sam, I'll send a revision shortly > > Sam > > /snip > >

Re: [PATCH v5 05/11] drm: Add helpers to kick off self refresh mode in drivers

2019-06-11 Thread Sam Ravnborg
Hi Sean. Small things here and there. Did not stare at this long enough to understand the code, but added some feedback anyway. Sam > > diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile > index d36feb4a62330..9d630a28a7880 100644 > --- a/drivers/gpu/drm/Makefile > +++

[PATCH v5 05/11] drm: Add helpers to kick off self refresh mode in drivers

2019-06-11 Thread Sean Paul
From: Sean Paul This patch adds a new drm helper library to help drivers implement self refresh. Drivers choosing to use it will register crtcs and will receive callbacks when it's time to enter or exit self refresh mode. In its current form, it has a timer which will trigger after a