Re: [PATCH v5 1/2] dt-bindings: Add doc for the Ingenic JZ47xx LCD controller driver
On Wed, Jun 12, 2019 at 10:49:52AM +0200, Paul Cercueil wrote: > > > Le mar. 11 juin 2019 à 23:55, Rob Herring a écrit : > > On Mon, 3 Jun 2019 17:23:30 +0200, Paul Cercueil wrote: > > > Add documentation for the devicetree bindings of the LCD controller > > > present in > > > the JZ47xx family of SoCs from Ingenic. > > > > > > Signed-off-by: Paul Cercueil > > > Tested-by: Artur Rojek > > > --- > > > > > > Notes: > > > v2: Remove ingenic,panel property. > > > > > > v3: - Rename compatible strings from ingenic,jz47XX-drm to > > > ingenic,jz47XX-lcd > > > - The ingenic,lcd-mode property is now read from the panel > > > node instead > > > of from the driver node > > > > > > v4: Remove ingenic,lcd-mode property completely. > > > > > > v5: No change > > > > > > .../bindings/display/ingenic,lcd.txt | 44 > > > +++ > > > 1 file changed, 44 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/display/ingenic,lcd.txt > > > > > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > > there's no need to repost patches *only* to add the tags. The upstream > > maintainer will do that for acks received on the version they apply. > > > > If a tag was not added on purpose, please state why and what changed. > > Sorry Rob, my mistake. I simply forgot that you ever reviewed that patch. Added Rob's r-b and pushed to drm-misc-next Sam ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v5 1/2] dt-bindings: Add doc for the Ingenic JZ47xx LCD controller driver
Le mar. 11 juin 2019 à 23:55, Rob Herring a écrit : On Mon, 3 Jun 2019 17:23:30 +0200, Paul Cercueil wrote: Add documentation for the devicetree bindings of the LCD controller present in the JZ47xx family of SoCs from Ingenic. Signed-off-by: Paul Cercueil Tested-by: Artur Rojek --- Notes: v2: Remove ingenic,panel property. v3: - Rename compatible strings from ingenic,jz47XX-drm to ingenic,jz47XX-lcd - The ingenic,lcd-mode property is now read from the panel node instead of from the driver node v4: Remove ingenic,lcd-mode property completely. v5: No change .../bindings/display/ingenic,lcd.txt | 44 +++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. Sorry Rob, my mistake. I simply forgot that you ever reviewed that patch. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v5 1/2] dt-bindings: Add doc for the Ingenic JZ47xx LCD controller driver
On Mon, 3 Jun 2019 17:23:30 +0200, Paul Cercueil wrote: > Add documentation for the devicetree bindings of the LCD controller present in > the JZ47xx family of SoCs from Ingenic. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > --- > > Notes: > v2: Remove ingenic,panel property. > > v3: - Rename compatible strings from ingenic,jz47XX-drm to > ingenic,jz47XX-lcd > - The ingenic,lcd-mode property is now read from the panel node > instead > of from the driver node > > v4: Remove ingenic,lcd-mode property completely. > > v5: No change > > .../bindings/display/ingenic,lcd.txt | 44 +++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed. ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH v5 1/2] dt-bindings: Add doc for the Ingenic JZ47xx LCD controller driver
Add documentation for the devicetree bindings of the LCD controller present in
the JZ47xx family of SoCs from Ingenic.
Signed-off-by: Paul Cercueil
Tested-by: Artur Rojek
---
Notes:
v2: Remove ingenic,panel property.
v3: - Rename compatible strings from ingenic,jz47XX-drm to
ingenic,jz47XX-lcd
- The ingenic,lcd-mode property is now read from the panel node instead
of from the driver node
v4: Remove ingenic,lcd-mode property completely.
v5: No change
.../bindings/display/ingenic,lcd.txt | 44 +++
1 file changed, 44 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/ingenic,lcd.txt
diff --git a/Documentation/devicetree/bindings/display/ingenic,lcd.txt
b/Documentation/devicetree/bindings/display/ingenic,lcd.txt
new file mode 100644
index ..7b536c8c6dde
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/ingenic,lcd.txt
@@ -0,0 +1,44 @@
+Ingenic JZ47xx LCD driver
+
+Required properties:
+- compatible: one of:
+ * ingenic,jz4740-lcd
+ * ingenic,jz4725b-lcd
+- reg: LCD registers location and length
+- clocks: LCD pixclock and device clock specifiers.
+ The device clock is only required on the JZ4740.
+- clock-names: "lcd_pclk" and "lcd"
+- interrupts: Specifies the interrupt line the LCD controller is connected to.
+
+Example:
+
+panel {
+ compatible = "sharp,ls020b1dd01d";
+
+ backlight = <&backlight>;
+ power-supply = <&vcc>;
+
+ port {
+ panel_input: endpoint {
+ remote-endpoint = <&panel_output>;
+ };
+ };
+};
+
+
+lcd: lcd-controller@1305 {
+ compatible = "ingenic,jz4725b-lcd";
+ reg = <0x1305 0x1000>;
+
+ interrupt-parent = <&intc>;
+ interrupts = <31>;
+
+ clocks = <&cgu JZ4725B_CLK_LCD>;
+ clock-names = "lcd";
+
+ port {
+ panel_output: endpoint {
+ remote-endpoint = <&panel_input>;
+ };
+ };
+};
--
2.21.0.593.g511ec345e18
