Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
On Wed, 2021-01-20 at 11:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > > Hi Laurentiu, > > > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > > Hi Liu Ying, > > > > > > I promised I would have a second, more

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-21 Thread Liu Ying
Hi Laurentiu, On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > Hi Liu Ying, > > I promised I would have a second, more in-depth, look at this and I finally > managed to do it. Thanks. > > I have to admit it was a challenge. Partially because I'm not very familiar > with DPU but

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-20 Thread Laurentiu Palcu
Hi Liu Ying, On Wed, Jan 20, 2021 at 04:42:50PM +0800, Liu Ying wrote: > Hi Laurentiu, > > On Fri, 2021-01-15 at 19:27 +0200, Laurentiu Palcu wrote: > > Hi Liu Ying, > > > > I promised I would have a second, more in-depth, look at this and I finally > > managed to do it. > > Thanks. > > > > > I

Re: [PATCH v5 5/6] drm/imx: Introduce i.MX8qm/qxp DPU DRM

2021-01-15 Thread Laurentiu Palcu
Hi Liu Ying, I promised I would have a second, more in-depth, look at this and I finally managed to do it. I have to admit it was a challenge. Partially because I'm not very familiar with DPU but mostly because of the abundance of macros used. It's true, macros make the code more compact.