Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-12 Thread Sam Ravnborg
On Wed, May 11, 2022 at 07:34:38PM +0200, Javier Martinez Canillas wrote: > Hello Guenter, > > On 5/11/22 19:17, Guenter Roeck wrote: > > On 5/11/22 10:00, Sam Ravnborg wrote: > > [snip] > > >>> struct fb_info *registered_fb[FB_MAX] __read_mostly; > >>> -EXPORT_SYMBOL(registered_fb); > >>> -

Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-11 Thread Javier Martinez Canillas
Hello Guenter, On 5/11/22 19:17, Guenter Roeck wrote: > On 5/11/22 10:00, Sam Ravnborg wrote: [snip] >>> struct fb_info *registered_fb[FB_MAX] __read_mostly; >>> -EXPORT_SYMBOL(registered_fb); >>> - >>> int num_registered_fb __read_mostly; >>> +#if IS_ENABLED(CONFIG_FB_OLPC_DCON) >>>

Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-11 Thread Guenter Roeck
On 5/11/22 10:00, Sam Ravnborg wrote: Hi Javier. On Wed, May 11, 2022 at 01:32:30PM +0200, Javier Martinez Canillas wrote: From: Daniel Vetter Well except when the olpc dcon fbdev driver is enabled, that thing digs around in there in rather unfixable ways. Cc oldc_dcon maintainers as fyi.

Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-11 Thread Sam Ravnborg
Hi Javier. On Wed, May 11, 2022 at 01:32:30PM +0200, Javier Martinez Canillas wrote: > From: Daniel Vetter > > Well except when the olpc dcon fbdev driver is enabled, that thing > digs around in there in rather unfixable ways. > > Cc oldc_dcon maintainers as fyi. Another way to fix this is to

[PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-11 Thread Javier Martinez Canillas
From: Daniel Vetter Well except when the olpc dcon fbdev driver is enabled, that thing digs around in there in rather unfixable ways. Cc oldc_dcon maintainers as fyi. v2: I typoed the config name (0day) Cc: kernel test robot Cc: Jens Frederich Cc: Jon Nettleton Cc: Greg Kroah-Hartman Cc: