Re: [PATCH v6 11/18] drm/virtio: switch from ttm to gem shmem helpers

2019-07-17 Thread Chia-I Wu
On Tue, Jul 2, 2019 at 7:19 AM Gerd Hoffmann wrote: > > virtio-gpu basically needs a sg_table for the bo, to tell the host where > the backing pages for the object are. So the gem shmem helpers are a > perfect fit. Some drm_gem_object_funcs need thin wrappers to update the > host state, but

Re: [PATCH v6 11/18] drm/virtio: switch from ttm to gem shmem helpers

2019-07-04 Thread Emil Velikov
Hi Gerd, On Tue, 2 Jul 2019 at 15:19, Gerd Hoffmann wrote: > .gem_prime_import_sg_table = virtgpu_gem_prime_import_sg_table, I think that you can drop this entry-point. AFAICT it's only purpose is to return an error - something already handled by core DRM when the function pointer is

[PATCH v6 11/18] drm/virtio: switch from ttm to gem shmem helpers

2019-07-02 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the