Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-10 Thread Mark Brown
On Fri, Jul 10, 2020 at 09:42:49AM +0200, Andrzej Hajda wrote: > But the provider does not know if *get is called in probe context or > not, so it is not able to differentiate it. > So the whole idea is for me suspicious/wrong. Kind of proof: > 1. If you insist that provider's EPROBE_ERROR

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-10 Thread Andrzej Hajda
On 07.07.2020 06:14, Dmitry Torokhov wrote: > On Thu, Jul 02, 2020 at 08:57:55AM +0200, Andrzej Hajda wrote: >> On 30.06.2020 20:00, Dmitry Torokhov wrote: >>> On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: On 30.06.2020 10:59, Grygorii Strashko wrote: > Hi > > On

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-07 Thread Dmitry Torokhov
On Thu, Jul 02, 2020 at 08:57:55AM +0200, Andrzej Hajda wrote: > > On 30.06.2020 20:00, Dmitry Torokhov wrote: > > On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > >> > >> On 30.06.2020 10:59, Grygorii Strashko wrote: > >>> Hi > >>> > >>> On 29/06/2020 14:28, Andrzej Hajda wrote: > Hi

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-02 Thread Andrzej Hajda
On 30.06.2020 20:00, Dmitry Torokhov wrote: > On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: >> >> On 30.06.2020 10:59, Grygorii Strashko wrote: >>> Hi >>> >>> On 29/06/2020 14:28, Andrzej Hajda wrote: Hi Grygorii, (...) >> /* >> * deferred_devs_show()

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-01 Thread Grygorii Strashko
Hi On 29/06/2020 14:28, Andrzej Hajda wrote: Hi Grygorii, (...)   /*    * deferred_devs_show() - Show the devices in the deferred probe pending list.    */ @@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s, void *data)   mutex_lock(_probe_mutex);    

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-07-01 Thread Dmitry Torokhov
On Tue, Jun 30, 2020 at 8:42 AM Andrzej Hajda wrote: > > > On 30.06.2020 10:59, Grygorii Strashko wrote: > > Hi > > > > On 29/06/2020 14:28, Andrzej Hajda wrote: > >> Hi Grygorii, > >> > >> (...) > >> > /* > * deferred_devs_show() - Show the devices in the deferred probe >

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-30 Thread Andrzej Hajda
On 30.06.2020 10:59, Grygorii Strashko wrote: > Hi > > On 29/06/2020 14:28, Andrzej Hajda wrote: >> Hi Grygorii, >> >> (...) >>    /*     * deferred_devs_show() - Show the devices in the deferred probe pending list.     */ @@ -221,7 +241,8 @@ static int

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-29 Thread Andrzej Hajda
Hi Grygorii, (...) >>   /* >>    * deferred_devs_show() - Show the devices in the deferred probe >> pending list. >>    */ >> @@ -221,7 +241,8 @@ static int deferred_devs_show(struct seq_file *s, >> void *data) >>   mutex_lock(_probe_mutex); >>     list_for_each_entry(curr,

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-27 Thread Grygorii Strashko
On 26/06/2020 13:01, Andrzej Hajda wrote: /sys/kernel/debug/devices_deferred property contains list of deferred devices. This list does not contain reason why the driver deferred probe, the patch improves it. The natural place to set the reason is probe_err function introduced recently, ie.

Re: [PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-26 Thread Rafael J. Wysocki
On Fri, Jun 26, 2020 at 12:01 PM Andrzej Hajda wrote: > > /sys/kernel/debug/devices_deferred property contains list of deferred devices. > This list does not contain reason why the driver deferred probe, the patch > improves it. > The natural place to set the reason is probe_err function

[PATCH v6 2/4] driver core: add deferring probe reason to devices_deferred property

2020-06-26 Thread Andrzej Hajda
/sys/kernel/debug/devices_deferred property contains list of deferred devices. This list does not contain reason why the driver deferred probe, the patch improves it. The natural place to set the reason is probe_err function introduced recently, ie. if probe_err will be called with -EPROBE_DEFER