Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

[Sam Ravnborg]

Hi Jitao.

On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
>  - fix boe_panel_init err uninit.
>  - adjust the delay of backlight on.
> 
> Changes since v5:
>  - covert the documents to yaml
>  - fine tune boe, tv101wum-n53 panel video timine

I finally found some time to looks at this.

The bindings does unfortunately not pass a dt_binding_check

I had to locally do the following to make on of the bindings pass:
diff --git 
a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml 
b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
   - Sam Ravnborg 
   - Rob Herring 

+allOf:
+  - $ref: panel-common.yaml#
+
 properties:
   compatible:
 const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
   backlight:
 description: phandle of the backlight device attached to the panel

+  port: true
+
 required:
  - compatible
  - reg
@@ -46,7 +51,9 @@ additionalProperties: false

 examples:
   - |
- {
+dsi {
+#address-cells = <1>;
+#size-cells = <0>;
 panel@0 {
 compatible = "auo,b101uan08.3";
 reg = <0>;

I will follow-up with review feedback on the drivers later as time
permits.

Sam



___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels

[Jitao Shi]

Changes since v6:
 - fix boe_panel_init err uninit.
 - adjust the delay of backlight on.

Changes since v5:
 - covert the documents to yaml
 - fine tune boe, tv101wum-n53 panel video timine

Changes since v4:
 - add auo,b101uan08.3 panel for this driver.
 - add boe,tv101wum-n53 panel for this driver.

Changes since v3:
 - remove check enable_gpio.
 - fine tune the auo,kd101n80-45na panel's power on timing.

Changes since v2:
 - correct the panel size
 - remove blank line in Kconfig
 - move auo,kd101n80-45na panel driver in this series.

Changes since v1:

 - update typo nl6 -> n16.
 - update new panel config and makefile are added in alphabetically order.
 - add the panel mode and panel info in driver data.
 - merge auo,kd101n80-45a and boe,tv101wum-nl6 in one driver

Jitao Shi (8):
  dt-bindings: display: panel: Add BOE tv101wum-n16 panel bindings
  drm/panel: support for BOE tv101wum-nl6 wuxga dsi video mode panel
  dt-bindings: display: panel: add auo kd101n80-45na panel bindings
  drm/panel: support for auo,kd101n80-45na wuxga dsi video mode panel
  dt-bindings: display: panel: add boe tv101wum-n53 panel documentation
  drm/panel: support for boe,tv101wum-n53 wuxga dsi video mode panel
  dt-bindings: display: panel: add AUO auo,b101uan08.3 panel
documentation
  drm/panel: support for auo,b101uan08.3 wuxga dsi video mode panel

 .../display/panel/auo,b101uan08.3.yaml|  67 ++
 .../display/panel/auo,kd101n80-45na.yaml  |  67 ++
 .../display/panel/boe,tv101wum-n53.yaml   |  67 ++
 .../display/panel/boe,tv101wum-nl6.yaml   |  67 ++
 drivers/gpu/drm/panel/Kconfig |   9 +
 drivers/gpu/drm/panel/Makefile|   1 +
 .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 880 ++
 7 files changed, 1158 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/panel/auo,kd101n80-45na.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/panel/boe,tv101wum-n53.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/panel/boe,tv101wum-nl6.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c

-- 
2.21.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel