[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Lukas Wunner
On Tue, Oct 04, 2016 at 02:23:13PM +0200, Lukas Wunner wrote: > On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote: > > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > > > Looks like crtc is a errno in the above case. I see this function is > > > called by looping through all the

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Lukas Wunner
On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > > Looks like crtc is a errno in the above case. I see this function is > > called by looping through all the crtc and we never check to see if > > they are valid. Should we?

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Jon Hunter
On 04/10/16 12:25, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: >> Looks like crtc is a errno in the above case. I see this function is >> called by looping through all the crtc and we never check to see if >> they are valid. Should we? > > Tegra is still using the

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Daniel Vetter
On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > Looks like crtc is a errno in the above case. I see this function is > called by looping through all the crtc and we never check to see if > they are valid. Should we? Tegra is still using the load/unload hooks. That didn't mesh well with

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Jon Hunter
Hi Tomeu, On 09/09/16 10:56, Tomeu Vizoso wrote: > Adds files and directories to debugfs for controlling and reading frame > CRCs, per CRTC: > > dri/0/crtc-0/crc > dri/0/crtc-0/crc/control > dri/0/crtc-0/crc/data > > Drivers can implement the set_crc_source callback() in drm_crtc_funcs to >

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-09-09 Thread Tomeu Vizoso
Adds files and directories to debugfs for controlling and reading frame CRCs, per CRTC: dri/0/crtc-0/crc dri/0/crtc-0/crc/control dri/0/crtc-0/crc/data Drivers can implement the set_crc_source callback() in drm_crtc_funcs to start and stop generating frame CRCs and can add entries to the output