Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2021-01-05 Thread Paul Kocialkowski
Hi, On Wed 23 Dec 20, 18:31, Ilia Mirkin wrote: > FWIW this is something I added, hoping it was going to get used at > some point, but I never followed up with support in xf86-video-nouveau > for Xv. At this point, I'm not sure I ever will. I encoded the > "enabled" part into the value with a

Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-12-23 Thread Ilia Mirkin
FWIW this is something I added, hoping it was going to get used at some point, but I never followed up with support in xf86-video-nouveau for Xv. At this point, I'm not sure I ever will. I encoded the "enabled" part into the value with a high bit (1<<24) -- not sure that was such a great idea. All

Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-12-23 Thread Simon Ser
nouveau already has something for colorkey: https://drmdb.emersion.fr/properties/4008636142/colorkey I know this is marked "not for merge", but it would be nice to discuss with them and come up with a standardized property. ___ dri-devel mailing list

[PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-12-23 Thread Paul Kocialkowski
Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/logicvc/logicvc_drm.h | 3 + drivers/gpu/drm/logicvc/logicvc_layer.c | 150 +++- drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++ 3 files changed, 154 insertions(+), 6 deletions(-) diff --git