Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 11:16 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 10:46:31AM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > > > The error messages are frequently in the caller rather than the > > > frameworks, it's often helpful for the

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 12:10 AM Greg Kroah-Hartman wrote: > > On Tue, Jul 28, 2020 at 05:05:03PM +0200, Andrzej Hajda wrote: > > Hi Greg, > > > > Apparently the patchset has no more comments. > > > > Could you take the patches to your tree? At least 1st and 2nd. > > All now queued up, thanks! I

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-31 Thread Dmitry Torokhov
On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > > > I believe it still has not been answered why this can't be pushed into > > resource providers (clock, regulators, gpio, interrupts, etc), > > especially for devm APIs where

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-30 Thread Mark Brown
On Thu, Jul 30, 2020 at 11:45:25AM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 11:16 AM Mark Brown wrote: > > You can sometimes do a better job of explaining what the resource you > > were looking for was, > I think it is true for very esoteric cases. I.e. your driver uses 2 >

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-30 Thread Mark Brown
On Thu, Jul 30, 2020 at 10:46:31AM -0700, Dmitry Torokhov wrote: > On Thu, Jul 30, 2020 at 9:49 AM Mark Brown wrote: > > The error messages are frequently in the caller rather than the > > frameworks, it's often helpful for the comprehensibility of the error > > messages especially in cases

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-30 Thread Mark Brown
On Thu, Jul 30, 2020 at 09:18:30AM -0700, Dmitry Torokhov wrote: > I believe it still has not been answered why this can't be pushed into > resource providers (clock, regulators, gpio, interrupts, etc), > especially for devm APIs where we know exactly what device we are > requesting a resource

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-30 Thread Greg Kroah-Hartman
On Tue, Jul 28, 2020 at 05:05:03PM +0200, Andrzej Hajda wrote: > Hi Greg, > > Apparently the patchset has no more comments. > > Could you take the patches to your tree? At least 1st and 2nd. All now queued up, thanks! greg k-h ___ dri-devel mailing

Re: [PATCH v9 0/4] driver core: add probe error check helper

2020-07-28 Thread Andrzej Hajda
Hi Greg, Apparently the patchset has no more comments. Could you take the patches to your tree? At least 1st and 2nd. Regards Andrzej On 13.07.2020 16:43, Andrzej Hajda wrote: > Hi All, > > Thanks for comments. > > Changes since v8: > - fixed typo in function name, > - removed cocci script

[PATCH v9 0/4] driver core: add probe error check helper

2020-07-13 Thread Andrzej Hajda
Hi All, Thanks for comments. Changes since v8: - fixed typo in function name, - removed cocci script (added by mistake) Changes since v7: - improved commit message - added R-Bs Changes since v6: - removed leftovers from old naming scheme in commit descritions, - added R-Bs. Changes since v5: