Re: [PATCHv2 09/22] drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable

2019-04-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Mar 26, 2019 at 12:31:33PM +0200, Tomi Valkeinen wrote: > We set up the PXL PLL inside tc_main_link_setup. This is unnecessary, > and makes tc_main_link_setup depend on the video-mode, which should not > be the case. As PXL PLL is used only for the video

Re: [PATCHv2 09/22] drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable

2019-04-15 Thread Andrzej Hajda
On 26.03.2019 11:31, Tomi Valkeinen wrote: > We set up the PXL PLL inside tc_main_link_setup. This is unnecessary, > and makes tc_main_link_setup depend on the video-mode, which should not > be the case. As PXL PLL is used only for the video stream (and only when > using the HW test pattern), let's

[PATCHv2 09/22] drm/bridge: tc358767: move PXL PLL enable/disable to stream enable/disable

2019-03-26 Thread Tomi Valkeinen
We set up the PXL PLL inside tc_main_link_setup. This is unnecessary, and makes tc_main_link_setup depend on the video-mode, which should not be the case. As PXL PLL is used only for the video stream (and only when using the HW test pattern), let's move the PXL PLL setup into tc_stream_enable. Als