Re: [PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-05-03 Thread Tomi Valkeinen
On 21/04/2019 01:13, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Mar 26, 2019 at 12:31:39PM +0200, Tomi Valkeinen wrote: >> The current link training code does unnecessary retry-loops, and does >> extra writes to the registers. It is easier to follow the flow and >

Re: [PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-04-20 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Tue, Mar 26, 2019 at 12:31:39PM +0200, Tomi Valkeinen wrote: > The current link training code does unnecessary retry-loops, and does > extra writes to the registers. It is easier to follow the flow and > ensure it's similar to Toshiba's documentation if we dea

Re: [PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-04-15 Thread Tomi Valkeinen
On 15/04/2019 12:54, Andrzej Hajda wrote: > On 26.03.2019 11:31, Tomi Valkeinen wrote: >> The current link training code does unnecessary retry-loops, and does >> extra writes to the registers. It is easier to follow the flow and >> ensure it's similar to Toshiba's documentation if we deal with LT

Re: [PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-04-15 Thread Andrzej Hajda
On 26.03.2019 11:31, Tomi Valkeinen wrote: > The current link training code does unnecessary retry-loops, and does > extra writes to the registers. It is easier to follow the flow and > ensure it's similar to Toshiba's documentation if we deal with LT inside > tc_main_link_enable() function. > > Th

[PATCHv2 15/22] drm/bridge: tc358767: clean-up link training

2019-03-26 Thread Tomi Valkeinen
The current link training code does unnecessary retry-loops, and does extra writes to the registers. It is easier to follow the flow and ensure it's similar to Toshiba's documentation if we deal with LT inside tc_main_link_enable() function. This patch adds tc_wait_link_training() which handles wa