[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 12:11:49PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: > > On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: > > > On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: > > > > On Wed, May 30, 2012

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: > On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: > > On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: > > > On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: > > > > The passed mode must not

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: > > On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: > > > The passed mode must not be modified by the operation, make it const. > > > > > >

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: > On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: > > The passed mode must not be modified by the operation, make it const. > > > > Signed-off-by: Laurent Pinchart > > Acked-by: Daniel Vetter Thank you for

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: > The passed mode must not be modified by the operation, make it const. > > Signed-off-by: Laurent Pinchart Acked-by: Daniel Vetter -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart --- This will break the i915 driver, as it modifies mode->clock in intel_dp_mode_fixup(), hence the RFC state. Is this incorrect behaviour from the i915 driver ?

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Daniel Vetter daniel.vet...@ffwll.ch -- Daniel Vetter Mail: dan...@ffwll.ch

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Daniel

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: Hi Daniel, On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must not be modified by the operation, make it const. Signed-off-by:

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must not be

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Daniel Vetter
On Wed, May 30, 2012 at 12:11:49PM +0200, Laurent Pinchart wrote: Hi Daniel, On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-29 Thread Laurent Pinchart
The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- This will break the i915 driver, as it modifies mode-clock in intel_dp_mode_fixup(), hence the RFC state. Is this incorrect behaviour from the i915 driver ?